Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: extensions/common/BUILD.gn

Issue 2843353004: Enable use_once_callback on mojom GN rule by default (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/wake_lock/public/interfaces/BUILD.gn ('k') | extensions/common/api/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//extensions/features/features.gni") 6 import("//extensions/features/features.gni")
7 import("//mojo/public/tools/bindings/mojom.gni") 7 import("//mojo/public/tools/bindings/mojom.gni")
8 8
9 source_set("common_constants") { 9 source_set("common_constants") {
10 sources = [ 10 sources = [
(...skipping 15 matching lines...) Expand all
26 ] 26 ]
27 27
28 if (proprietary_codecs && enable_wifi_display) { 28 if (proprietary_codecs && enable_wifi_display) {
29 sources += [ "mojo/wifi_display_session_service.mojom" ] 29 sources += [ "mojo/wifi_display_session_service.mojom" ]
30 } 30 }
31 31
32 public_deps = [ 32 public_deps = [
33 "//mojo/common:common_custom_types", 33 "//mojo/common:common_custom_types",
34 "//url/mojo:url_mojom_gurl", 34 "//url/mojo:url_mojom_gurl",
35 ] 35 ]
36
37 # TODO(crbug.com/714018): Convert the implementation to use OnceCallback.
38 use_once_callback = false
36 } 39 }
37 40
38 # This must be a static library because extensions common depends on 41 # This must be a static library because extensions common depends on
39 # GetTrustedICAPublicKey in extensions/browser which isn't always linked 42 # GetTrustedICAPublicKey in extensions/browser which isn't always linked
40 # in. TODO(brettw): This reverse dependency should be fixed. 43 # in. TODO(brettw): This reverse dependency should be fixed.
41 static_library("common") { 44 static_library("common") {
42 sources = [ 45 sources = [
43 "alias.h", 46 "alias.h",
44 "api/bluetooth/bluetooth_manifest_data.cc", 47 "api/bluetooth/bluetooth_manifest_data.cc",
45 "api/bluetooth/bluetooth_manifest_data.h", 48 "api/bluetooth/bluetooth_manifest_data.h",
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 "//ui/base", 387 "//ui/base",
385 "//ui/gfx", 388 "//ui/gfx",
386 "//url", 389 "//url",
387 ] 390 ]
388 391
389 if (is_chromeos) { 392 if (is_chromeos) {
390 sources += [ "manifest_handlers/action_handlers_handler_unittest.cc" ] 393 sources += [ "manifest_handlers/action_handlers_handler_unittest.cc" ]
391 } 394 }
392 } 395 }
393 } # enable_extensions 396 } # enable_extensions
OLDNEW
« no previous file with comments | « device/wake_lock/public/interfaces/BUILD.gn ('k') | extensions/common/api/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698