Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Side by Side Diff: mojo/public/tools/bindings/mojom.gni

Issue 2843353004: Enable use_once_callback on mojom GN rule by default (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 declare_args() { 5 declare_args() {
6 # Indicates whether typemapping should be supported in this build 6 # Indicates whether typemapping should be supported in this build
7 # configuration. This may be disabled when building external projects which 7 # configuration. This may be disabled when building external projects which
8 # depend on //mojo but which do not need/want all of the Chromium tree 8 # depend on //mojo but which do not need/want all of the Chromium tree
9 # dependencies that come with typemapping. 9 # dependencies that come with typemapping.
10 # 10 #
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 # 119 #
120 # visibility (optional) 120 # visibility (optional)
121 # 121 #
122 # visibility_blink (optional) 122 # visibility_blink (optional)
123 # The value to use for visibility for the blink variant. If unset, 123 # The value to use for visibility for the blink variant. If unset,
124 # |visibility| is used. 124 # |visibility| is used.
125 # 125 #
126 # use_once_callback (optional) 126 # use_once_callback (optional)
127 # If set to true, generated classes will use base::OnceCallback instead of 127 # If set to true, generated classes will use base::OnceCallback instead of
128 # base::RepeatingCallback. 128 # base::RepeatingCallback.
129 # Default value is false. 129 # Default value is true.
130 # TODO(dcheng): 130 # TODO(dcheng):
131 # - Convert everything to use OnceCallback. 131 # - Convert everything to use OnceCallback.
132 # - Remove support for the old mode. 132 # - Remove support for the old mode.
133 # 133 #
134 # cpp_only (optional) 134 # cpp_only (optional)
135 # If set to true, only the C++ bindings targets will be generated. 135 # If set to true, only the C++ bindings targets will be generated.
136 # 136 #
137 # use_new_js_bindings (optional) 137 # use_new_js_bindings (optional)
138 # If set to true, the generated JS code will use the new module loading 138 # If set to true, the generated JS code will use the new module loading
139 # approach and the core API exposed by Web IDL. 139 # approach and the core API exposed by Web IDL.
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
431 if (defined(invoker.export_class_attribute)) { 431 if (defined(invoker.export_class_attribute)) {
432 args += [ 432 args += [
433 "--export_attribute", 433 "--export_attribute",
434 invoker.export_class_attribute, 434 invoker.export_class_attribute,
435 "--export_header", 435 "--export_header",
436 invoker.export_header, 436 invoker.export_header,
437 ] 437 ]
438 } 438 }
439 } 439 }
440 440
441 if (defined(invoker.use_once_callback) && invoker.use_once_callback) { 441 if (!defined(invoker.use_once_callback) || invoker.use_once_callback) {
442 args += [ "--use_once_callback" ] 442 args += [ "--use_once_callback" ]
443 } 443 }
444 444
445 if (defined(invoker.use_new_js_bindings) && 445 if (defined(invoker.use_new_js_bindings) &&
446 invoker.use_new_js_bindings) { 446 invoker.use_new_js_bindings) {
447 args += [ "--use_new_js_bindings" ] 447 args += [ "--use_new_js_bindings" ]
448 } 448 }
449 } 449 }
450 } 450 }
451 451
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
655 full_name = get_label_info(d, "label_no_toolchain") 655 full_name = get_label_info(d, "label_no_toolchain")
656 deps += [ "${full_name}_java" ] 656 deps += [ "${full_name}_java" ]
657 } 657 }
658 658
659 srcjar_deps = [ ":$java_srcjar_target_name" ] 659 srcjar_deps = [ ":$java_srcjar_target_name" ]
660 run_findbugs_override = false 660 run_findbugs_override = false
661 } 661 }
662 } 662 }
663 } 663 }
664 } 664 }
OLDNEW
« no previous file with comments | « mojo/public/interfaces/bindings/tests/BUILD.gn ('k') | services/catalog/public/interfaces/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698