Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2841603004: [Payments] Update some editor titles to reflect missing information (Closed)

Created:
3 years, 8 months ago by Mathieu
Modified:
3 years, 8 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews, gogerald+paymentswatch_chromium.org, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Update some editor titles to reflect missing information Title of editor should reflect missing information, or a more generic message otherwise. BUG=712074 TEST=manual Review-Url: https://codereview.chromium.org/2841603004 Cr-Commit-Position: refs/heads/master@{#466972} Committed: https://chromium.googlesource.com/chromium/src/+/752dfc391d00506d24824d2a1b35c5224f265e4d

Patch Set 1 : Initial #

Total comments: 2

Patch Set 2 : Cleanup some strings #

Messages

Total messages: 14 (8 generated)
Mathieu
Anthony, PTAL!
3 years, 8 months ago (2017-04-25 12:35:41 UTC) #3
anthonyvd
lgtm https://codereview.chromium.org/2841603004/diff/20001/components/payments_strings.grdp File components/payments_strings.grdp (right): https://codereview.chromium.org/2841603004/diff/20001/components/payments_strings.grdp#newcode100 components/payments_strings.grdp:100: <message name="IDS_PAYMENTS_EDIT_ADDRESS" desc="Text on a button that lets ...
3 years, 8 months ago (2017-04-25 12:39:33 UTC) #4
Mathieu
Thanks, PTAL? https://codereview.chromium.org/2841603004/diff/20001/components/payments_strings.grdp File components/payments_strings.grdp (right): https://codereview.chromium.org/2841603004/diff/20001/components/payments_strings.grdp#newcode100 components/payments_strings.grdp:100: <message name="IDS_PAYMENTS_EDIT_ADDRESS" desc="Text on a button that ...
3 years, 8 months ago (2017-04-25 12:54:46 UTC) #6
anthonyvd
lgtm
3 years, 8 months ago (2017-04-25 12:58:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841603004/40001
3 years, 8 months ago (2017-04-25 13:06:29 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 13:38:18 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/752dfc391d00506d24824d2a1b35...

Powered by Google App Engine
This is Rietveld 408576698