Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Unified Diff: chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc

Issue 2841603004: [Payments] Update some editor titles to reflect missing information (Closed)
Patch Set: Cleanup some strings Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
diff --git a/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc b/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
index d857a944f0cceacb3e30223a8ec69131d665b3a4..03680275598688b6ffa9b8ac524f0c6eb543c647 100644
--- a/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
+++ b/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc
@@ -273,8 +273,15 @@ CreditCardEditorViewController::GetComboboxModelForType(
}
base::string16 CreditCardEditorViewController::GetSheetTitle() {
- return l10n_util::GetStringUTF16(
- IDS_PAYMENT_REQUEST_CREDIT_CARD_EDITOR_ADD_TITLE);
+ if (!credit_card_to_edit_)
+ return l10n_util::GetStringUTF16(IDS_PAYMENTS_ADD_CARD);
+
+ // Gets the completion message, or empty if nothing is missing from the card.
+ base::string16 title = autofill::GetCompletionMessageForCard(
+ autofill::GetCompletionStatusForCard(*credit_card_to_edit_,
+ state()->GetApplicationLocale()));
+ return title.empty() ? l10n_util::GetStringUTF16(IDS_PAYMENTS_EDIT_CARD)
+ : title;
}
CreditCardEditorViewController::CreditCardValidationDelegate::

Powered by Google App Engine
This is Rietveld 408576698