chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc - Issue 2841603004: [Payments] Update some editor titles to reflect missing information

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc

Issue 2841603004: [Payments] Update some editor titles to reflect missing information (Closed)

Patch Set: Cleanup some strings Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc

diff --git a/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc b/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc

index 7a5b319d4632c8ad38ceda178e6f73db0128ea1c..32bbdd919c781bf7b615731098e802c905d88c8d 100644

--- a/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc

+++ b/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc

@@ -103,6 +103,8 @@ ContactInfoEditorViewController::GetComboboxModelForType(

}

base::string16 ContactInfoEditorViewController::GetSheetTitle() {

+ // TODO(crbug.com/712074): Title should reflect the missing information, if

+ // applicable.

return profile_to_edit_ ? l10n_util::GetStringUTF16(

IDS_PAYMENTS_EDIT_CONTACT_DETAILS_LABEL)

: l10n_util::GetStringUTF16(

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc » ('j') | no next file with comments »