Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Unified Diff: chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc

Issue 2841603004: [Payments] Update some editor titles to reflect missing information (Closed)
Patch Set: Cleanup some strings Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/payments/payment_sheet_view_controller.cc ('k') | components/payments_strings.grdp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
diff --git a/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc b/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
index b479cacf8bca08dac0818c76557583dd4f21dd5e..e6babf41d8909d0a28b11b2f3a91a2cead55fb87 100644
--- a/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
+++ b/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
@@ -207,8 +207,10 @@ void ShippingAddressEditorViewController::UpdateEditorView() {
}
base::string16 ShippingAddressEditorViewController::GetSheetTitle() {
- return l10n_util::GetStringUTF16(
- IDS_PAYMENT_REQUEST_ADDRESS_EDITOR_ADD_TITLE);
+ // TODO(crbug.com/712074): Editor title should reflect the missing information
+ // in the case that one or more fields are missing.
+ return profile_to_edit_ ? l10n_util::GetStringUTF16(IDS_PAYMENTS_EDIT_ADDRESS)
+ : l10n_util::GetStringUTF16(IDS_PAYMENTS_ADD_ADDRESS);
}
void ShippingAddressEditorViewController::UpdateEditorFields() {
« no previous file with comments | « chrome/browser/ui/views/payments/payment_sheet_view_controller.cc ('k') | components/payments_strings.grdp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698