Move offline related functions from Tab to OfflinePageUtils

Move offline related functions from Tab to OfflinePageUtils

BUG=715260
Review-Url: https://codereview.chromium.org/2838773002
Cr-Commit-Position: refs/heads/master@{#467143}
Committed: https://chromium.googlesource.com/chromium/src/+/f5fbad7f77e6e39ee8c5d3ec7516447b72128ddc

[jianli, 2017-04-24 23:46:49]

The CQ bit was checked by jianli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 23:47:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jianli, 2017-04-24 23:50:20]

jianli@chromium.org changed reviewers:
+ dfalcantara@chromium.org, fgorski@chromium.org

[commit-bot: I haz the power, 2017-04-24 23:58:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 23:58:32]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jianli, 2017-04-25 00:23:42]

The CQ bit was checked by jianli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 00:24:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 00:50:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 00:50:21]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[fgorski, 2017-04-25 16:52:25]

hey, I see no problems with in this patch or the idea behind it, but could you
add a bug for it and explain why you are doing the change?

If this is a setup for solving another problem, that would be useful to mention
too. (and maybe you could use that bug.

[jianli, 2017-04-25 19:49:02]

This is per tedchoc's feedback some time ago when we tried to add more
offline functionalities into Tab. He proposed to move them all to
OfflinePageUtils in order not to burden Tab. I think this is a good idea.

I will file a new bug on this.

On Tue, Apr 25, 2017 at 9:52 AM, <fgorski@chromium.org> wrote:

> hey, I see no problems with in this patch or the idea behind it, but could
> you
> add a bug for it and explain why you are doing the change?
>
> If this is a setup for solving another problem, that would be useful to
> mention
> too. (and maybe you could use that bug.
>
> https://codereview.chromium.org/2838773002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jianli, 2017-04-25 20:40:21]

Description was changed from

==========
Move offline related functions from Tab to OfflinePageUtils

BUG=none
==========

to

==========
Move offline related functions from Tab to OfflinePageUtils

BUG=715260
==========

[jianli, 2017-04-25 20:42:15]

Bug has been created.

[gone, 2017-04-25 20:44:53]

lgtm

https://codereview.chromium.org/2838773002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
(right):

https://codereview.chromium.org/2838773002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java:484:
*/
@Nullable

[jianli, 2017-04-25 21:21:28]

https://codereview.chromium.org/2838773002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
(right):

https://codereview.chromium.org/2838773002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java:484:
*/
On 2017/04/25 20:44:53, slow (dfalcantara) wrote:
> @Nullable

Done.

[jianli, 2017-04-25 21:27:51]

The CQ bit was checked by jianli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 21:28:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2017-04-25 21:34:23]

lgtm

[commit-bot: I haz the power, 2017-04-25 22:21:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 22:21:58]

Dry run: This issue passed the CQ dry run.

[jianli, 2017-04-25 22:22:17]

The CQ bit was checked by jianli@chromium.org

[jianli, 2017-04-25 22:22:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2838773002/#ps40001
(title: "Fix tests")

[commit-bot: I haz the power, 2017-04-25 22:22:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 22:35:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493158937078100,
"parent_rev": "1f264da2cfe8d40c211f07ce3960898e5c998773", "commit_rev":
"f5fbad7f77e6e39ee8c5d3ec7516447b72128ddc"}

[commit-bot: I haz the power, 2017-04-25 22:36:02]

Description was changed from

==========
Move offline related functions from Tab to OfflinePageUtils

BUG=715260
==========

to

==========
Move offline related functions from Tab to OfflinePageUtils

BUG=715260

Review-Url: https://codereview.chromium.org/2838773002
Cr-Commit-Position: refs/heads/master@{#467143}
Committed:
https://chromium.googlesource.com/chromium/src/+/f5fbad7f77e6e39ee8c5d3ec7516...
==========

[commit-bot: I haz the power, 2017-04-25 22:36:04]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f5fbad7f77e6e39ee8c5d3ec7516...