chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java - Issue 2838773002: Move offline related functions from Tab to OfflinePageUtils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2838773002: Move offline related functions from Tab to OfflinePageUtils (Closed)

Patch Set: Fix tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

index f39d09dd79f18d2b8d5c39e1b3baff9eead02ec9..ca0009bde040ea58b8c747c3170dee6c658669db 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

@@ -1253,7 +1253,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity

WebContents webContents = currentTab.getWebContents();

RecordHistogram.recordBooleanHistogram(

- "OfflinePages.SharedPageWasOffline", currentTab.isOfflinePage());

+ "OfflinePages.SharedPageWasOffline", OfflinePageUtils.isOfflinePage(currentTab));

boolean canShareOfflinePage = OfflinePageBridge.isPageSharingEnabled();

// Share an empty blockingUri in place of screenshot file. The file ready notification is

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java » ('j') | no next file with comments »