Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2838773002: Move offline related functions from Tab to OfflinePageUtils (Closed)
Patch Set: Fix tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index 0775f9740179ebdf45452a6947c46c454ce1be4e..6ffe22381f2edb2afe9e9ca8c9dfecf79b5d724b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -66,7 +66,6 @@ import org.chromium.chrome.browser.infobar.InfoBarContainer;
import org.chromium.chrome.browser.media.ui.MediaSessionTabHelper;
import org.chromium.chrome.browser.ntp.NativePageAssassin;
import org.chromium.chrome.browser.ntp.NativePageFactory;
-import org.chromium.chrome.browser.offlinepages.OfflinePageItem;
import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;
import org.chromium.chrome.browser.policy.PolicyAuditor;
import org.chromium.chrome.browser.prerender.ExternalPrerenderHandler;
@@ -836,7 +835,7 @@ public class Tab
*/
public void reload() {
// TODO(dtrainor): Should we try to rebuild the ContentView if it's frozen?
- if (isOfflinePage()) {
+ if (OfflinePageUtils.isOfflinePage(this)) {
// If current page is an offline page, reload it with custom behavior defined in extra
// header respected.
OfflinePageUtils.reload(this);
@@ -2661,30 +2660,6 @@ public class Tab
}
/**
- * @return True if the offline page is opened.
- */
- public boolean isOfflinePage() {
- return isFrozen() ? false : nativeIsOfflinePage(mNativeTabAndroid);
- }
-
- /**
- * @return The offline page if tab currently displays it, null otherwise.
- */
- public OfflinePageItem getOfflinePage() {
- return isFrozen() ? null : nativeGetOfflinePage(mNativeTabAndroid);
- }
-
- /**
- * Shows the list of offline pages. This should only be hit when offline pages feature is
- * enabled.
- */
- @CalledByNative
- public void showOfflinePages() {
- // TODO(jianli): This is not currently used. Figure out what to do here.
- // http://crbug.com/636574
- }
-
- /**
* @return Original url of the tab, which is the original url from DOMDistiller.
*/
public String getOriginalUrl() {
@@ -3094,8 +3069,6 @@ public class Tab
long nativeTabAndroid, int constraints, int current, boolean animate);
private native void nativeLoadOriginalImage(long nativeTabAndroid);
private native long nativeGetBookmarkId(long nativeTabAndroid, boolean onlyEditable);
- private native boolean nativeIsOfflinePage(long nativeTabAndroid);
- private native OfflinePageItem nativeGetOfflinePage(long nativeTabAndroid);
private native void nativeSetInterceptNavigationDelegate(long nativeTabAndroid,
InterceptNavigationDelegate delegate);
private native void nativeAttachToTabContentManager(long nativeTabAndroid,

Powered by Google App Engine
This is Rietveld 408576698