chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java - Issue 2838773002: Move offline related functions from Tab to OfflinePageUtils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java

Issue 2838773002: Move offline related functions from Tab to OfflinePageUtils (Closed)

Patch Set: Fix tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java

index e5dc7328d46e9df58bdd66e180e4cdd917f8347e..0b0e37b610ba4544ad3bdba157f10e97ba261a2a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java

@@ -41,6 +41,7 @@ import org.chromium.chrome.browser.download.ui.DownloadFilter;

import org.chromium.chrome.browser.download.ui.DownloadHistoryItemWrapper;

import org.chromium.chrome.browser.offlinepages.DownloadUiActionFlags;

import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;

+import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;

import org.chromium.chrome.browser.offlinepages.downloads.OfflinePageDownloadBridge;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;

@@ -243,7 +244,7 @@ public class DownloadUtils {

if (tab.isShowingInterstitialPage()) return false;

// Don't allow re-downloading the currently displayed offline page.

- if (tab.isOfflinePage()) return false;

+ if (OfflinePageUtils.isOfflinePage(tab)) return false;

return true;

}