chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java - Issue 2838773002: Move offline related functions from Tab to OfflinePageUtils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java

Issue 2838773002: Move offline related functions from Tab to OfflinePageUtils (Closed)

Patch Set: Fix tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageRequestTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java

index cfd52f1d859c7d50fd70ccf2f0908e174eb8c390..4ab12eac9db981ffca32235be01f27281bd1f3eb 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java

@@ -115,7 +115,7 @@ class ToolbarModelImpl extends ToolbarModel implements ToolbarDataProvider, Tool

displayText =

DomDistillerTabUtils.getFormattedUrlFromOriginalDistillerUrl(originalUrl);

}

- } else if (mTab.isOfflinePage()

+ } else if (OfflinePageUtils.isOfflinePage(mTab)

&& mTab.getSecurityLevel() == ConnectionSecurityLevel.NONE) {

String originalUrl = mTab.getOriginalUrl();

displayText = OfflinePageUtils.stripSchemeFromOnlineUrl(