Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserverTest.java

Issue 2838773002: Move offline related functions from Tab to OfflinePageUtils (Closed)
Patch Set: Fix tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserverTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserverTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserverTest.java
index 6eb6186c0c2c9c0e32fdaf787f65de6c9978d5a6..a901d2506b28b84786cb2baa46662514e68fa721 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserverTest.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserverTest.java
@@ -62,6 +62,7 @@ public class OfflinePageTabObserverTest {
doReturn(false).when(observer).isShowingOfflinePreview(any(Tab.class));
// TODO(fgorski): This call has to be mocked out until we update OfflinePageUtils.
doNothing().when(observer).showReloadSnackbar(any(Tab.class));
+ doReturn(true).when(observer).isOfflinePage(any(Tab.class));
// Assert tab model observer was created.
assertTrue(observer.getTabModelObserver() != null);
return observer;
@@ -76,7 +77,6 @@ public class OfflinePageTabObserverTest {
doReturn(TAB_ID).when(mTab).getId();
doReturn(false).when(mTab).isFrozen();
doReturn(false).when(mTab).isHidden();
- doReturn(true).when(mTab).isOfflinePage();
doReturn(mActivity).when(mTab).getActivity();
// Setting up mock snackbar manager.
@@ -130,14 +130,14 @@ public class OfflinePageTabObserverTest {
public void testStartObservingTab() {
OfflinePageTabObserver observer = createObserver();
- doReturn(false).when(mTab).isOfflinePage();
+ doReturn(false).when(observer).isOfflinePage(any(Tab.class));
observer.startObservingTab(mTab);
assertFalse(observer.isObservingNetworkChanges());
assertFalse(observer.isObservingTab(mTab));
verify(observer, times(0)).showReloadSnackbar(any(Tab.class));
- doReturn(true).when(mTab).isOfflinePage();
+ doReturn(true).when(observer).isOfflinePage(any(Tab.class));
observer.startObservingTab(mTab);
assertTrue(observer.isObservingNetworkChanges());
@@ -400,7 +400,7 @@ public class OfflinePageTabObserverTest {
verify(mSnackbarManager, times(1)).dismissSnackbars(eq(mSnackbarController));
// URL updated and tab no longer shows offline page.
- doReturn(false).when(mTab).isOfflinePage();
+ doReturn(false).when(observer).isOfflinePage(any(Tab.class));
observer.onUrlUpdated(mTab);
assertFalse(observer.isObservingTab(mTab));
@@ -432,7 +432,7 @@ public class OfflinePageTabObserverTest {
observer.onPageLoadFinished(mTab);
// URL updated and tab no longer shows offline page.
- doReturn(false).when(mTab).isOfflinePage();
+ doReturn(false).when(observer).isOfflinePage(any(Tab.class));
observer.onUrlUpdated(mTab);
assertFalse(observer.isObservingTab(mTab));

Powered by Google App Engine
This is Rietveld 408576698