[DMC #1.913] Rename DocumentMarkerController::RemoveMarkers() to RemoveMarkersOfTypes()

Rename DocumentMarkerController::RemoveMarkers() to RemoveMarkersOfTypes()

yosin pointed out that it's confusing to have so many methods named
RemoveMarkers():
https://codereview.chromium.org/2820633002#msg30

This is the third of several renaming CLs I'm going to upload

BUG=707867
Review-Url: https://codereview.chromium.org/2836563002
Cr-Commit-Position: refs/heads/master@{#466575}
Committed: https://chromium.googlesource.com/chromium/src/+/1945a87fa4e60d4749fc02db1a939e21c3470e63

[rlanday, 2017-04-21 03:41:58]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-04-21 03:42:11]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[commit-bot: I haz the power, 2017-04-21 03:42:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-04-21 03:44:28]

Description was changed from

==========
Rename DocumentMarkerController::RemoveMarkers() to RemoveAllMarkers()

yosin pointed out that it's confusing to have so many methods named
RemoveMarkers():
https://codereview.chromium.org/2820633002#msg30

This is the second of several renaming CLs I'm going to upload

BUG=707867
==========

to

==========
Rename DocumentMarkerController::RemoveMarkers() to RemoveAllMarkers()

yosin pointed out that it's confusing to have so many methods named
RemoveMarkers():
https://codereview.chromium.org/2820633002#msg30

This is the third of several renaming CLs I'm going to upload

BUG=707867
==========

[Xiaocheng, 2017-04-21 05:25:02]

How about RemoveMarkersOfTypes?

RemoveAllMarkers sounds like clearing everything.

[rlanday, 2017-04-21 05:39:05]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-04-21 05:39:22]

Description was changed from

==========
Rename DocumentMarkerController::RemoveMarkers() to RemoveAllMarkers()

yosin pointed out that it's confusing to have so many methods named
RemoveMarkers():
https://codereview.chromium.org/2820633002#msg30

This is the third of several renaming CLs I'm going to upload

BUG=707867
==========

to

==========
Rename DocumentMarkerController::RemoveMarkers() to RemoveMarkersOfTypes()

yosin pointed out that it's confusing to have so many methods named
RemoveMarkers():
https://codereview.chromium.org/2820633002#msg30

This is the third of several renaming CLs I'm going to upload

BUG=707867
==========

[rlanday, 2017-04-21 05:39:29]

On 2017/04/21 at 05:25:02, xiaochengh wrote:
> How about RemoveMarkersOfTypes?
> 
> RemoveAllMarkers sounds like clearing everything.

Ok, I've changed it

[commit-bot: I haz the power, 2017-04-21 05:39:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 07:11:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 07:11:30]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-04-21 07:59:54]

lgtm

[yosin_UTC9, 2017-04-21 08:22:36]

lgtm

https://codereview.chromium.org/2836563002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
(right):

https://codereview.chromium.org/2836563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h:81:
void RemoveMarkersOfTypes(DocumentMarker::MarkerTypes);
Good catch! We should not use default parameter for this function.

[rlanday, 2017-04-21 08:30:09]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-04-21 08:30:09]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org,
xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2836563002/#ps40001
(title: "Remove dependency")

[commit-bot: I haz the power, 2017-04-21 08:30:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 08:30:20]

This CL has an open dependency (Issue 2829723006 Patch 40001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[rlanday, 2017-04-21 23:36:23]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-04-21 23:36:23]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org,
xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2836563002/#ps60001
(title: "Rebase, remove dep")

[commit-bot: I haz the power, 2017-04-21 23:37:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 23:47:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 23:47:24]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rlanday, 2017-04-22 09:59:56]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-04-22 09:59:57]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org,
xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2836563002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-22 10:00:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-22 10:07:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-22 10:07:23]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rlanday, 2017-04-22 10:08:32]

rlanday@chromium.org changed reviewers:
+ tkent@chromium.org

[rlanday, 2017-04-22 10:09:48]

Adding tkent as an OWNER of:
  third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp
  third_party/WebKit/Source/web/TextFinder.cpp

[tkent, 2017-04-23 23:48:04]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-04-23 23:48:05]

lgtm

[commit-bot: I haz the power, 2017-04-23 23:48:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 01:14:51]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492991284187090,
"parent_rev": "75e518861ddbdf82531605d1bdf4d678e8d4ffe6", "commit_rev":
"1945a87fa4e60d4749fc02db1a939e21c3470e63"}

[commit-bot: I haz the power, 2017-04-24 01:15:01]

Description was changed from

==========
Rename DocumentMarkerController::RemoveMarkers() to RemoveMarkersOfTypes()

yosin pointed out that it's confusing to have so many methods named
RemoveMarkers():
https://codereview.chromium.org/2820633002#msg30

This is the third of several renaming CLs I'm going to upload

BUG=707867
==========

to

==========
Rename DocumentMarkerController::RemoveMarkers() to RemoveMarkersOfTypes()

yosin pointed out that it's confusing to have so many methods named
RemoveMarkers():
https://codereview.chromium.org/2820633002#msg30

This is the third of several renaming CLs I'm going to upload

BUG=707867

Review-Url: https://codereview.chromium.org/2836563002
Cr-Commit-Position: refs/heads/master@{#466575}
Committed:
https://chromium.googlesource.com/chromium/src/+/1945a87fa4e60d4749fc02db1a93...
==========

[commit-bot: I haz the power, 2017-04-24 01:15:02]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/1945a87fa4e60d4749fc02db1a93...