Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1454)

Unified Diff: third_party/WebKit/Source/web/TextFinder.cpp

Issue 2836563002: [DMC #1.913] Rename DocumentMarkerController::RemoveMarkers() to RemoveMarkersOfTypes() (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/TextFinder.cpp
diff --git a/third_party/WebKit/Source/web/TextFinder.cpp b/third_party/WebKit/Source/web/TextFinder.cpp
index 89dce6f0c757077aa866fb35c9a0302057a9d99c..428fbca2aee1b26f536b0ed3921ef439a30e2361 100644
--- a/third_party/WebKit/Source/web/TextFinder.cpp
+++ b/third_party/WebKit/Source/web/TextFinder.cpp
@@ -232,7 +232,7 @@ void TextFinder::StopFindingAndClearSelection() {
CancelPendingScopingEffort();
// Remove all markers for matches found and turn off the highlighting.
- OwnerFrame().GetFrame()->GetDocument()->Markers().RemoveMarkers(
+ OwnerFrame().GetFrame()->GetDocument()->Markers().RemoveMarkersOfTypes(
DocumentMarker::kTextMatch);
OwnerFrame().GetFrame()->GetEditor().SetMarkedTextMatchesAreHighlighted(
false);
@@ -709,8 +709,10 @@ bool TextFinder::SetMarkerActive(Range* range, bool active) {
void TextFinder::UnmarkAllTextMatches() {
LocalFrame* frame = OwnerFrame().GetFrame();
if (frame && frame->GetPage() &&
- frame->GetEditor().MarkedTextMatchesAreHighlighted())
- frame->GetDocument()->Markers().RemoveMarkers(DocumentMarker::kTextMatch);
+ frame->GetEditor().MarkedTextMatchesAreHighlighted()) {
+ frame->GetDocument()->Markers().RemoveMarkersOfTypes(
+ DocumentMarker::kTextMatch);
+ }
}
bool TextFinder::ShouldScopeMatches(const String& search_text,
« no previous file with comments | « third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698