Geolocation cleanup: use unique_ptr<>s and rename New{WlanApi/PollingPolicy} to CreateBla()

Geolocation cleanup: use unique_ptr<>s and rename New{WlanApi/PollingPolicy} to CreateBla() 

Cleanup to renamed NewWlanApi to CreateWlanApi and
NewPollingPolicy() to CreatePollingPolicy(), and made them 
return unique_ptr<> ISO a naked ptrs. 

Also in  device/geolocation/wifi_data_provider_win.cc
removed {} for one-line bodies and also had to change the
signaure of two internal Create() methods (and make
ctors public to be accessible by base::MakeUnique<>).

BUG=714348
Review-Url: https://codereview.chromium.org/2833273002
Cr-Commit-Position: refs/heads/master@{#466771}
Committed: https://chromium.googlesource.com/chromium/src/+/b477ea757773359fb6d25a643815ded1c0660909

[mcasas, 2017-04-22 18:29:00]

Patchset #1 (id:1) has been deleted

[mcasas, 2017-04-22 18:29:09]

Patchset #1 (id:20001) has been deleted

[mcasas, 2017-04-22 18:29:18]

Patchset #1 (id:40001) has been deleted

[mcasas, 2017-04-24 02:01:06]

Patchset #3 (id:100001) has been deleted

[mcasas, 2017-04-24 02:01:12]

Patchset #2 (id:80001) has been deleted

[mcasas, 2017-04-24 02:20:19]

Description was changed from

==========
Geolocation cleanup: renamed New{WlanApi/PollingPolicy} to Create... and adapted
code to use unique_ptr<>s


Renamed-adapted New{WlanApi/PollingPolicy} to Create... and adapted code to use
unique_ptr<>s

BUG=714348
==========

to

==========
Geolocation cleanup: use unique_ptr<>s and rename New{WlanApi/PollingPolicy} to
CreateBla() 

Cleanup to renamed NewWlanApi to CreateWlanApi and
NewPollingPolicy() to CreatePollingPolicy(), and made them 
return unique_ptr<> ISO a naked ptrs. 

Also in  device/geolocation/wifi_data_provider_win.cc
removed {} for one-line bodies and also had to change the
signaure of two internal Create() methods (and make
ctors public to be accessible by base::MakeUnique<>).

BUG=714348
==========

[mcasas, 2017-04-24 02:25:07]

Patchset #1 (id:60001) has been deleted

[mcasas, 2017-04-24 02:34:02]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 02:34:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2017-04-24 02:34:45]

mcasas@chromium.org changed reviewers:
+ reillyg@chromium.org

[mcasas, 2017-04-24 02:34:46]

reillyg@ PTAL

[commit-bot: I haz the power, 2017-04-24 03:55:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 03:55:57]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[mcasas, 2017-04-24 05:50:49]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[mcasas, 2017-04-24 05:50:55]

Patchset #1 (id:120001) has been deleted

[commit-bot: I haz the power, 2017-04-24 05:50:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 08:39:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 08:39:58]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2017-04-24 19:42:33]

lgtm with nits

https://codereview.chromium.org/2833273002/diff/140001/device/geolocation/wif...
File device/geolocation/wifi_data_provider_linux_unittest.cc (right):

https://codereview.chromium.org/2833273002/diff/140001/device/geolocation/wif...
device/geolocation/wifi_data_provider_linux_unittest.cc:96:
ASSERT_TRUE(wlan_api_.get());
ASSERT_TRUE(wlan_api_);

https://codereview.chromium.org/2833273002/diff/140001/device/geolocation/wif...
File device/geolocation/wifi_data_provider_win.cc (right):

https://codereview.chromium.org/2833273002/diff/140001/device/geolocation/wif...
device/geolocation/wifi_data_provider_win.cc:434: if (buffer == NULL)
!buffer

[mcasas, 2017-04-24 19:47:30]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[mcasas, 2017-04-24 19:47:35]

https://codereview.chromium.org/2833273002/diff/140001/device/geolocation/wif...
File device/geolocation/wifi_data_provider_linux_unittest.cc (right):

https://codereview.chromium.org/2833273002/diff/140001/device/geolocation/wif...
device/geolocation/wifi_data_provider_linux_unittest.cc:96:
ASSERT_TRUE(wlan_api_.get());
On 2017/04/24 19:42:33, Reilly Grant wrote:
> ASSERT_TRUE(wlan_api_);

Done.

https://codereview.chromium.org/2833273002/diff/140001/device/geolocation/wif...
File device/geolocation/wifi_data_provider_win.cc (right):

https://codereview.chromium.org/2833273002/diff/140001/device/geolocation/wif...
device/geolocation/wifi_data_provider_win.cc:434: if (buffer == NULL)
On 2017/04/24 19:42:33, Reilly Grant wrote:
> !buffer

Done.

[commit-bot: I haz the power, 2017-04-24 19:48:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 20:59:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 20:59:33]

Dry run: This issue passed the CQ dry run.

[mcasas, 2017-04-24 21:19:40]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2017-04-24 21:19:40]

The patchset sent to the CQ was uploaded after l-g-t-m from reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2833273002/#ps160001
(title: "reillyg@s nits")

[commit-bot: I haz the power, 2017-04-24 21:20:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 21:24:48]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1493068780073160,
"parent_rev": "783d491b68d1b5833b65accba2e4fd595f09a404", "commit_rev":
"b477ea757773359fb6d25a643815ded1c0660909"}

[commit-bot: I haz the power, 2017-04-24 21:24:59]

Description was changed from

==========
Geolocation cleanup: use unique_ptr<>s and rename New{WlanApi/PollingPolicy} to
CreateBla() 

Cleanup to renamed NewWlanApi to CreateWlanApi and
NewPollingPolicy() to CreatePollingPolicy(), and made them 
return unique_ptr<> ISO a naked ptrs. 

Also in  device/geolocation/wifi_data_provider_win.cc
removed {} for one-line bodies and also had to change the
signaure of two internal Create() methods (and make
ctors public to be accessible by base::MakeUnique<>).

BUG=714348
==========

to

==========
Geolocation cleanup: use unique_ptr<>s and rename New{WlanApi/PollingPolicy} to
CreateBla() 

Cleanup to renamed NewWlanApi to CreateWlanApi and
NewPollingPolicy() to CreatePollingPolicy(), and made them 
return unique_ptr<> ISO a naked ptrs. 

Also in  device/geolocation/wifi_data_provider_win.cc
removed {} for one-line bodies and also had to change the
signaure of two internal Create() methods (and make
ctors public to be accessible by base::MakeUnique<>).

BUG=714348

Review-Url: https://codereview.chromium.org/2833273002
Cr-Commit-Position: refs/heads/master@{#466771}
Committed:
https://chromium.googlesource.com/chromium/src/+/b477ea757773359fb6d25a643815...
==========

[commit-bot: I haz the power, 2017-04-24 21:25:01]

Committed patchset #2 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/b477ea757773359fb6d25a643815...