Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3584)

Unified Diff: device/geolocation/wifi_data_provider_common_unittest.cc

Issue 2833273002: Geolocation cleanup: use unique_ptr<>s and rename New{WlanApi/PollingPolicy} to CreateBla() (Closed)
Patch Set: reillyg@s nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/geolocation/wifi_data_provider_common.cc ('k') | device/geolocation/wifi_data_provider_linux.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/geolocation/wifi_data_provider_common_unittest.cc
diff --git a/device/geolocation/wifi_data_provider_common_unittest.cc b/device/geolocation/wifi_data_provider_common_unittest.cc
index 4e837b7966417a13c176e605b57becc25e2019e6..8afde8ca862d9d9643f5857b473d5a613f35134b 100644
--- a/device/geolocation/wifi_data_provider_common_unittest.cc
+++ b/device/geolocation/wifi_data_provider_common_unittest.cc
@@ -62,9 +62,11 @@ class WifiDataProviderCommonWithMock : public WifiDataProviderCommon {
: wlan_api_(new MockWlanApi), polling_policy_(new MockPollingPolicy) {}
// WifiDataProviderCommon
- WlanApiInterface* NewWlanApi() override { return wlan_api_.release(); }
- WifiPollingPolicy* NewPollingPolicy() override {
- return polling_policy_.release();
+ std::unique_ptr<WlanApiInterface> CreateWlanApi() override {
+ return std::move(wlan_api_);
+ }
+ std::unique_ptr<WifiPollingPolicy> CreatePollingPolicy() override {
+ return std::move(polling_policy_);
}
std::unique_ptr<MockWlanApi> wlan_api_;
« no previous file with comments | « device/geolocation/wifi_data_provider_common.cc ('k') | device/geolocation/wifi_data_provider_linux.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698