Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2318)

Unified Diff: device/geolocation/wifi_data_provider_common.h

Issue 2833273002: Geolocation cleanup: use unique_ptr<>s and rename New{WlanApi/PollingPolicy} to CreateBla() (Closed)
Patch Set: reillyg@s nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | device/geolocation/wifi_data_provider_common.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/geolocation/wifi_data_provider_common.h
diff --git a/device/geolocation/wifi_data_provider_common.h b/device/geolocation/wifi_data_provider_common.h
index a569af1e01dfc23608eacc0c349ce87db345de8c..44a312cb4eda1b1e1c405305e7df4a078f852c90 100644
--- a/device/geolocation/wifi_data_provider_common.h
+++ b/device/geolocation/wifi_data_provider_common.h
@@ -53,9 +53,9 @@ class DEVICE_GEOLOCATION_EXPORT WifiDataProviderCommon
// TODO(mcasas): change return types and possibly names of these two methods,
// see https://crbug.com/714348.
// Returns ownership.
- virtual WlanApiInterface* NewWlanApi() = 0;
+ virtual std::unique_ptr<WlanApiInterface> CreateWlanApi() = 0;
// Returns ownership.
- virtual WifiPollingPolicy* NewPollingPolicy() = 0;
+ virtual std::unique_ptr<WifiPollingPolicy> CreatePollingPolicy() = 0;
private:
// Runs a scan. Calls the callbacks if new data is found.
« no previous file with comments | « no previous file | device/geolocation/wifi_data_provider_common.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698