device/geolocation/wifi_data_provider_mac.h - Issue 2833273002: Geolocation cleanup: use unique_ptr<>s and rename New{WlanApi/PollingPolicy} to CreateBla()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/geolocation/wifi_data_provider_mac.h

Issue 2833273002: Geolocation cleanup: use unique_ptr<>s and rename New{WlanApi/PollingPolicy} to CreateBla() (Closed)

Patch Set: reillyg@s nits Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/geolocation/wifi_data_provider_mac.h

diff --git a/device/geolocation/wifi_data_provider_mac.h b/device/geolocation/wifi_data_provider_mac.h

index 42f28984d56655f923727520957ef643d87cdab7..0c38c3a2c911e4a042fdcde339dc9a0dcaa45bd9 100644

--- a/device/geolocation/wifi_data_provider_mac.h

+++ b/device/geolocation/wifi_data_provider_mac.h

@@ -20,9 +20,9 @@ class WifiDataProviderMac : public WifiDataProviderCommon {

private:

~WifiDataProviderMac() override;

- // WifiDataProviderCommon

- WlanApiInterface* NewWlanApi() override;

- WifiPollingPolicy* NewPollingPolicy() override;

+ // WifiDataProviderCommon implementation

+ std::unique_ptr<WlanApiInterface> CreateWlanApi() override;

+ std::unique_ptr<WifiPollingPolicy> CreatePollingPolicy() override;

DISALLOW_COPY_AND_ASSIGN(WifiDataProviderMac);

};