Geolocation cleanup: use unique_ptr<>s and rename New{WlanApi/PollingPolicy} to CreateBla()

device/geolocation/wifi_data_provider_linux_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/geolocation/wifi_data_provider_linux.h"
 
 #include <stdint.h>
 
 #include <memory>
 
@@ skipping 74 matching lines @@
         GetObjectProxy(
             "org.freedesktop.NetworkManager",
             dbus::ObjectPath("/org/freedesktop/NetworkManager/AccessPoint/0")))
         .WillOnce(Return(mock_access_point_proxy_.get()));
 
     // ShutdownAndBlock() should be called.
     EXPECT_CALL(*mock_bus_.get(), ShutdownAndBlock()).WillOnce(Return());
 
     // Create the wlan API with the mock bus object injected.
     wifi_provider_linux_ = new WifiDataProviderLinux;
-    wlan_api_.reset(
-        wifi_provider_linux_->NewWlanApiForTesting(mock_bus_.get()));
+    wlan_api_ = wifi_provider_linux_->CreateWlanApiForTesting(mock_bus_.get());
     ASSERT_TRUE(wlan_api_.get());

[Reilly Grant (use Gerrit), 2017/04/24 19:42:33]

ASSERT_TRUE(wlan_api_);

[mcasas, 2017/04/24 19:47:35]

Done.

   }
 
  protected:
   // WifiDataProvider requires a task runner to be present. The |message_loop_|
   // is defined here, as it should outlive |wifi_provider_linux_|.
   base::MessageLoopForUI message_loop_;
   scoped_refptr<dbus::MockBus> mock_bus_;
   scoped_refptr<dbus::MockObjectProxy> mock_network_manager_proxy_;
   scoped_refptr<dbus::MockObjectProxy> mock_access_point_proxy_;
   scoped_refptr<dbus::MockObjectProxy> mock_device_proxy_;
@@ skipping 111 matching lines @@
   // Check the contents of the access point data.
   // The expected values come from CreateAccessPointProxyResponse() above.
   EXPECT_EQ("test", base::UTF16ToUTF8(access_point_data.ssid));
   EXPECT_EQ("00-11-22-33-44-55",
             base::UTF16ToUTF8(access_point_data.mac_address));
   EXPECT_EQ(-50, access_point_data.radio_signal_strength);
   EXPECT_EQ(4, access_point_data.channel);
 }
 
 }  // namespace device