Geolocation cleanup: use unique_ptr<>s and rename New{WlanApi/PollingPolicy} to CreateBla()

device/geolocation/wifi_data_provider_win.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Windows Vista uses the Native Wifi (WLAN) API for accessing WiFi cards. See
 // http://msdn.microsoft.com/en-us/library/ms705945(VS.85).aspx. Windows XP
 // Service Pack 3 (and Windows XP Service Pack 2, if upgraded with a hot fix)
 // also support a limited version of the WLAN API. See
 // http://msdn.microsoft.com/en-us/library/bb204766.aspx. The WLAN API uses
 // wlanapi.h, which is not part of the SDK used by Gears, so is replicated
@@ skipping 10 matching lines @@
 // not to work on XP SP3. So we use WLAN on Vista, and use NDIS directly
 // otherwise.
 
 #include "device/geolocation/wifi_data_provider_win.h"
 
 #include <windows.h>
 #include <winioctl.h>
 #include <wlanapi.h>
 
 #include "base/memory/free_deleter.h"
+#include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/win/windows_version.h"
 #include "device/geolocation/wifi_data_provider_common.h"
 #include "device/geolocation/wifi_data_provider_common_win.h"
 #include "device/geolocation/wifi_data_provider_manager.h"
 
 // Taken from ndis.h for WinCE.
 #define NDIS_STATUS_INVALID_LENGTH ((NDIS_STATUS)0xC0010014L)
 #define NDIS_STATUS_BUFFER_TOO_SHORT ((NDIS_STATUS)0xC0010016L)
@@ skipping 38 matching lines @@
 // WlanFreeMemory
 typedef VOID(WINAPI* WlanFreeMemoryFunction)(PVOID pMemory);
 
 // WlanCloseHandle
 typedef DWORD(WINAPI* WlanCloseHandleFunction)(HANDLE hClientHandle,
                                                PVOID pReserved);
 
 // Local classes and functions
 class WindowsWlanApi : public WifiDataProviderCommon::WlanApiInterface {
  public:
+  // Factory function. Will return NULL if this API is unavailable.
+  static std::unique_ptr<WindowsWlanApi> Create();
+
+  // Takes ownership of the library handle.
+  explicit WindowsWlanApi(HINSTANCE library);
   ~WindowsWlanApi() override;
-  // Factory function. Will return NULL if this API is unavailable.
-  static WindowsWlanApi* Create();
 
   // WlanApiInterface
   bool GetAccessPointData(WifiData::AccessPointDataSet* data) override;
 
  private:
-  // Takes ownership of the library handle.
-  explicit WindowsWlanApi(HINSTANCE library);
-
   // Loads the required functions from the DLL.
   void GetWLANFunctions(HINSTANCE wlan_library);
   int GetInterfaceDataWLAN(HANDLE wlan_handle,
                            const GUID& interface_id,
                            WifiData::AccessPointDataSet* data);
 
   // Logs number of detected wlan interfaces.
   static void LogWlanInterfaceCount(int count);
 
   // Handle to the wlanapi.dll library.
   HINSTANCE library_;
 
   // Function pointers for WLAN
   WlanOpenHandleFunction WlanOpenHandle_function_;
   WlanEnumInterfacesFunction WlanEnumInterfaces_function_;
   WlanGetNetworkBssListFunction WlanGetNetworkBssList_function_;
   WlanFreeMemoryFunction WlanFreeMemory_function_;
   WlanCloseHandleFunction WlanCloseHandle_function_;
 };
 
 class WindowsNdisApi : public WifiDataProviderCommon::WlanApiInterface {
  public:
+  static std::unique_ptr<WindowsNdisApi> Create();
+
+  // Swaps in content of the vector passed
+  explicit WindowsNdisApi(std::vector<base::string16>* interface_service_names);
   ~WindowsNdisApi() override;
-  static WindowsNdisApi* Create();
 
   // WlanApiInterface
   bool GetAccessPointData(WifiData::AccessPointDataSet* data) override;
 
  private:
   static bool GetInterfacesNDIS(
       std::vector<base::string16>* interface_service_names_out);
-
-  // Swaps in content of the vector passed
-  explicit WindowsNdisApi(std::vector<base::string16>* interface_service_names);
-
   bool GetInterfaceDataNDIS(HANDLE adapter_handle,
                             WifiData::AccessPointDataSet* data);
   // NDIS variables.
   std::vector<base::string16> interface_service_names_;
 
   // Remembers scan result buffer size across calls.
   int oid_buffer_size_;
 };
 
 // Extracts data for an access point and converts to Gears format.
 bool GetNetworkData(const WLAN_BSS_ENTRY& bss_entry,
                     AccessPointData* access_point_data);
 bool UndefineDosDevice(const base::string16& device_name);
 bool DefineDosDeviceIfNotExists(const base::string16& device_name);
 HANDLE GetFileHandle(const base::string16& device_name);
 // Makes the OID query and returns a Windows API error code.
 int PerformQuery(HANDLE adapter_handle,
                  BYTE* buffer,
                  DWORD buffer_size,
                  DWORD* bytes_out);
 bool ResizeBuffer(int requested_size,
                   std::unique_ptr<BYTE, base::FreeDeleter>* buffer);
 // Gets the system directory and appends a trailing slash if not already
 // present.
 bool GetSystemDirectory(base::string16* path);
-}  // namespace
+}  // anonymous namespace
 
 WifiDataProvider* WifiDataProviderManager::DefaultFactoryFunction() {
   return new WifiDataProviderWin();
 }
 
 WifiDataProviderWin::WifiDataProviderWin() {}
 
 WifiDataProviderWin::~WifiDataProviderWin() {}
 
-WifiDataProviderCommon::WlanApiInterface* WifiDataProviderWin::NewWlanApi() {
+std::unique_ptr<WifiDataProviderCommon::WlanApiInterface>
+WifiDataProviderWin::CreateWlanApi() {
   // Use the WLAN interface if we're on Vista and if it's available. Otherwise,
   // use NDIS.
-  WlanApiInterface* api = WindowsWlanApi::Create();
-  if (api) {
+  std::unique_ptr<WlanApiInterface> api = WindowsWlanApi::Create();
+  if (api)
     return api;
-  }
   return WindowsNdisApi::Create();
 }
 
-WifiPollingPolicy* WifiDataProviderWin::NewPollingPolicy() {
-  return new GenericWifiPollingPolicy<
+std::unique_ptr<WifiPollingPolicy> WifiDataProviderWin::CreatePollingPolicy() {
+  return base::MakeUnique<GenericWifiPollingPolicy<
       kDefaultPollingInterval, kNoChangePollingInterval,
-      kTwoNoChangePollingInterval, kNoWifiPollingIntervalMilliseconds>;
+      kTwoNoChangePollingInterval, kNoWifiPollingIntervalMilliseconds>>();
 }
 
 // Local classes and functions
 namespace {
 
 // WindowsWlanApi
 WindowsWlanApi::WindowsWlanApi(HINSTANCE library) : library_(library) {
   GetWLANFunctions(library_);
 }
 
 WindowsWlanApi::~WindowsWlanApi() {
   FreeLibrary(library_);
 }
 
-WindowsWlanApi* WindowsWlanApi::Create() {
+std::unique_ptr<WindowsWlanApi> WindowsWlanApi::Create() {
   if (base::win::GetVersion() < base::win::VERSION_VISTA)
-    return NULL;
+    return nullptr;
   // We use an absolute path to load the DLL to avoid DLL preloading attacks.
   base::string16 system_directory;
-  if (!GetSystemDirectory(&system_directory)) {
-    return NULL;
-  }
+  if (!GetSystemDirectory(&system_directory))
+    return nullptr;
   DCHECK(!system_directory.empty());
   base::string16 dll_path = system_directory + L"wlanapi.dll";
   HINSTANCE library =
       LoadLibraryEx(dll_path.c_str(), NULL, LOAD_WITH_ALTERED_SEARCH_PATH);
-  if (!library) {
-    return NULL;
-  }
-  return new WindowsWlanApi(library);
+  if (!library)
+    return nullptr;
+  return base::MakeUnique<WindowsWlanApi>(library);
 }
 
 void WindowsWlanApi::GetWLANFunctions(HINSTANCE wlan_library) {
   DCHECK(wlan_library);
   WlanOpenHandle_function_ = reinterpret_cast<WlanOpenHandleFunction>(
       GetProcAddress(wlan_library, "WlanOpenHandle"));
   WlanEnumInterfaces_function_ = reinterpret_cast<WlanEnumInterfacesFunction>(
       GetProcAddress(wlan_library, "WlanEnumInterfaces"));
   WlanGetNetworkBssList_function_ =
       reinterpret_cast<WlanGetNetworkBssListFunction>(
@@ skipping 116 matching lines @@
 // WindowsNdisApi
 WindowsNdisApi::WindowsNdisApi(
     std::vector<base::string16>* interface_service_names)
     : oid_buffer_size_(kInitialBufferSize) {
   DCHECK(!interface_service_names->empty());
   interface_service_names_.swap(*interface_service_names);
 }
 
 WindowsNdisApi::~WindowsNdisApi() {}
 
-WindowsNdisApi* WindowsNdisApi::Create() {
+std::unique_ptr<WindowsNdisApi> WindowsNdisApi::Create() {
   std::vector<base::string16> interface_service_names;
-  if (GetInterfacesNDIS(&interface_service_names)) {
-    return new WindowsNdisApi(&interface_service_names);
-  }
-  return NULL;
+  if (GetInterfacesNDIS(&interface_service_names))
+    return base::MakeUnique<WindowsNdisApi>(&interface_service_names);
+  return nullptr;
 }
 
 bool WindowsNdisApi::GetAccessPointData(WifiData::AccessPointDataSet* data) {
   DCHECK(data);
   int interfaces_failed = 0;
   int interfaces_succeeded = 0;
 
   for (int i = 0; i < static_cast<int>(interface_service_names_.size()); ++i) {
     // First, check that we have a DOS device for this adapter.
-    if (!DefineDosDeviceIfNotExists(interface_service_names_[i])) {
+    if (!DefineDosDeviceIfNotExists(interface_service_names_[i]))
       continue;
-    }
 
     // Get the handle to the device. This will fail if the named device is not
     // valid.
     HANDLE adapter_handle = GetFileHandle(interface_service_names_[i]);
-    if (adapter_handle == INVALID_HANDLE_VALUE) {
+    if (adapter_handle == INVALID_HANDLE_VALUE)
       continue;
-    }
 
     // Get the data.
-    if (GetInterfaceDataNDIS(adapter_handle, data)) {
+    if (GetInterfaceDataNDIS(adapter_handle, data))
       ++interfaces_succeeded;
-    } else {
+    else
       ++interfaces_failed;
-    }
 
     // Clean up.
     CloseHandle(adapter_handle);
     UndefineDosDevice(interface_service_names_[i]);
   }
 
   // Return true if at least one interface succeeded, or at the very least none
   // failed.
   return interfaces_succeeded > 0 || interfaces_failed == 0;
 }
@@ skipping 38 matching lines @@
   RegCloseKey(network_cards_key);
   return true;
 }
 
 bool WindowsNdisApi::GetInterfaceDataNDIS(HANDLE adapter_handle,
                                           WifiData::AccessPointDataSet* data) {
   DCHECK(data);
 
   std::unique_ptr<BYTE, base::FreeDeleter> buffer(
       static_cast<BYTE*>(malloc(oid_buffer_size_)));
-  if (buffer == NULL) {
+  if (buffer == NULL)

[Reilly Grant (use Gerrit), 2017/04/24 19:42:33]

!buffer

[mcasas, 2017/04/24 19:47:35]

Done.

     return false;
-  }
 
   DWORD bytes_out;
   int result;
 
   while (true) {
     bytes_out = 0;
     result = PerformQuery(adapter_handle, buffer.get(), oid_buffer_size_,
                           &bytes_out);
     if (result == ERROR_GEN_FAILURE ||  // Returned by some Intel cards.
         result == ERROR_INSUFFICIENT_BUFFER || result == ERROR_MORE_DATA ||
         result == NDIS_STATUS_INVALID_LENGTH ||
         result == NDIS_STATUS_BUFFER_TOO_SHORT) {
       // The buffer we supplied is too small, so increase it. bytes_out should
       // provide the required buffer size, but this is not always the case.
-      if (bytes_out > static_cast<DWORD>(oid_buffer_size_)) {
+      if (bytes_out > static_cast<DWORD>(oid_buffer_size_))
         oid_buffer_size_ = bytes_out;
-      } else {
+      else
         oid_buffer_size_ *= 2;
-      }
+
       if (!ResizeBuffer(oid_buffer_size_, &buffer)) {
         oid_buffer_size_ = kInitialBufferSize;  // Reset for next time.
         return false;
       }
     } else {
       // The buffer is not too small.
       break;
     }
   }
   DCHECK(buffer.get());
@@ skipping 36 matching lines @@
   // We create a DOS device name for the device at \Device\<device_name>.
   base::string16 target_path = L"\\Device\\" + device_name;
 
   TCHAR target[kStringLength];
   if (QueryDosDevice(device_name.c_str(), target, kStringLength) > 0 &&
       target_path.compare(target) == 0) {
     // Device already exists.
     return true;
   }
 
-  if (GetLastError() != ERROR_FILE_NOT_FOUND) {
+  if (GetLastError() != ERROR_FILE_NOT_FOUND)
     return false;
-  }
 
   if (!DefineDosDevice(DDD_RAW_TARGET_PATH, device_name.c_str(),
                        target_path.c_str())) {
     return false;
   }
 
   // Check that the device is really there.
   return QueryDosDevice(device_name.c_str(), target, kStringLength) > 0 &&
          target_path.compare(target) == 0;
 }
@@ skipping 34 matching lines @@
 
   buffer->reset(
       reinterpret_cast<BYTE*>(realloc(buffer->release(), requested_size)));
   return buffer != NULL;
 }
 
 bool GetSystemDirectory(base::string16* path) {
   DCHECK(path);
   // Return value includes terminating NULL.
   int buffer_size = ::GetSystemDirectory(NULL, 0);
-  if (buffer_size == 0) {
+  if (buffer_size == 0)
     return false;
-  }
   std::unique_ptr<base::char16[]> buffer(new base::char16[buffer_size]);
 
   // Return value excludes terminating NULL.
   int characters_written = ::GetSystemDirectory(buffer.get(), buffer_size);
-  if (characters_written == 0) {
+  if (characters_written == 0)
     return false;
-  }
   DCHECK_EQ(buffer_size - 1, characters_written);
 
   path->assign(buffer.get(), characters_written);
 
-  if (*path->rbegin() != L'\\') {
+  if (*path->rbegin() != L'\\')
     path->append(L"\\");
-  }
   DCHECK_EQ(L'\\', *path->rbegin());
   return true;
 }
 }  // namespace
 
 }  // namespace device