Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2830563002: Remove the unused "Disable non-blocking IO" QUIC experiment code. (Closed)

Created:
3 years, 8 months ago by Ryan Hamilton
Modified:
3 years, 8 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the unused "Disable non-blocking IO" QUIC experiment code. Review-Url: https://codereview.chromium.org/2830563002 Cr-Commit-Position: refs/heads/master@{#465633} Committed: https://chromium.googlesource.com/chromium/src/+/8c1a5a94f1a65987c50d7156144753ad05b1e10e

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -36 lines) Patch
M components/network_session_configurator/network_session_configurator.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M components/network_session_configurator/network_session_configurator_unittest.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/http_network_session.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.h View 2 chunks +0 lines, -4 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 3 chunks +1 line, -4 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 1 3 chunks +1 line, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (17 generated)
Ryan Hamilton
Hi Cherie, You already approved https://codereview.chromium.org/2253753002/ which uses non-blocking by default. Alas, that's having problems ...
3 years, 8 months ago (2017-04-19 03:39:40 UTC) #2
Zhongyi Shi
lgtm
3 years, 8 months ago (2017-04-19 04:15:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830563002/1
3 years, 8 months ago (2017-04-19 13:34:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/415086)
3 years, 8 months ago (2017-04-19 13:41:45 UTC) #11
commit-bot: I haz the power
This CL has an open dependency (Issue 2820573004 Patch 260001). Please resolve the dependency and ...
3 years, 8 months ago (2017-04-19 14:11:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830563002/20001
3 years, 8 months ago (2017-04-19 16:25:32 UTC) #21
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 16:33:46 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8c1a5a94f1a65987c50d71561447...

Powered by Google App Engine
This is Rietveld 408576698