Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: components/network_session_configurator/network_session_configurator.cc

Issue 2830563002: Remove the unused "Disable non-blocking IO" QUIC experiment code. (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/network_session_configurator/network_session_configurator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/network_session_configurator/network_session_configurator.cc
diff --git a/components/network_session_configurator/network_session_configurator.cc b/components/network_session_configurator/network_session_configurator.cc
index a0432839a1aea6fdffeeaf39fb2d2fd6d107a21c..f7754e834b91f5906e5dab7a33f5baf818f1b2e9 100644
--- a/components/network_session_configurator/network_session_configurator.cc
+++ b/components/network_session_configurator/network_session_configurator.cc
@@ -134,12 +134,6 @@ net::QuicTagVector GetQuicConnectionOptions(
return net::ParseQuicConnectionOptions(it->second);
}
-bool ShouldQuicEnableNonBlockingIO(
- const VariationParameters& quic_trial_params) {
- return base::LowerCaseEqualsASCII(
- GetVariationParam(quic_trial_params, "enable_non_blocking_io"), "true");
-}
-
bool ShouldForceHolBlocking(const VariationParameters& quic_trial_params) {
return base::LowerCaseEqualsASCII(
GetVariationParam(quic_trial_params, "force_hol_blocking"), "true");
@@ -273,8 +267,6 @@ void ConfigureQuicParams(base::StringPiece quic_trial_group,
ShouldRetryWithoutAltSvcOnQuicErrors(quic_trial_params);
if (params->enable_quic) {
- params->quic_enable_non_blocking_io =
- ShouldQuicEnableNonBlockingIO(quic_trial_params);
params->quic_force_hol_blocking = ShouldForceHolBlocking(quic_trial_params);
params->quic_connection_options =
GetQuicConnectionOptions(quic_trial_params);
« no previous file with comments | « no previous file | components/network_session_configurator/network_session_configurator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698