Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: components/network_session_configurator/network_session_configurator_unittest.cc

Issue 2830563002: Remove the unused "Disable non-blocking IO" QUIC experiment code. (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/network_session_configurator/network_session_configurator_unittest.cc
diff --git a/components/network_session_configurator/network_session_configurator_unittest.cc b/components/network_session_configurator/network_session_configurator_unittest.cc
index b9a21af5e9c7183f624cec89b4af544682c97560..a4deda3607f3bea92764eda5496b34f7576cda6e 100644
--- a/components/network_session_configurator/network_session_configurator_unittest.cc
+++ b/components/network_session_configurator/network_session_configurator_unittest.cc
@@ -71,7 +71,6 @@ TEST_F(NetworkSessionConfiguratorTest, EnableQuicFromFieldTrialGroup) {
EXPECT_EQ(1350u, params_.quic_max_packet_length);
EXPECT_EQ(net::QuicTagVector(), params_.quic_connection_options);
EXPECT_FALSE(params_.enable_server_push_cancellation);
- EXPECT_FALSE(params_.quic_enable_non_blocking_io);
EXPECT_FALSE(params_.quic_close_sessions_on_ip_change);
EXPECT_EQ(net::kIdleConnectionTimeoutSeconds,
params_.quic_idle_connection_timeout_seconds);
@@ -336,17 +335,6 @@ TEST_F(NetworkSessionConfiguratorTest, Http2SettingsFromFieldTrialParams) {
EXPECT_EQ(expected_settings, params_.http2_settings);
}
-TEST_F(NetworkSessionConfiguratorTest, QuicEnableNonBlockingIO) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["enable_non_blocking_io"] = "true";
- variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
-
- ParseFieldTrials();
-
- EXPECT_TRUE(params_.quic_enable_non_blocking_io);
-}
-
TEST_F(NetworkSessionConfiguratorTest, TCPFastOpenHttpsEnabled) {
base::FieldTrialList::CreateFieldTrial("TCPFastOpen", "HttpsEnabled");
« no previous file with comments | « components/network_session_configurator/network_session_configurator.cc ('k') | net/http/http_network_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698