Remove the code to store and load QUIC server configs in the disk cache.

Remove the code to store and load QUIC server configs in the disk cache.

This includes the load_server_info_time_to_srtt, enable_connection_racing and disable_disk_cache finch options.

BUG=707953
Review-Url: https://codereview.chromium.org/2820573004
Cr-Original-Commit-Position: refs/heads/master@{#465474}
Committed: https://chromium.googlesource.com/chromium/src/+/6f3dd74bddb23a2e5e74ba6976f02f94d76d2dda
Review-Url: https://codereview.chromium.org/2820573004
Cr-Commit-Position: refs/heads/master@{#465613}
Committed: https://chromium.googlesource.com/chromium/src/+/431dd44543668f59e341aaf350f1370690ee9b35

[Ryan Hamilton, 2017-04-15 03:50:21]

Description was changed from

==========
Remove the code to store QUIC server configs in the disk cache.
==========

to

==========
Remove the code to store and load QUIC server configs in the disk cache.

This includes the load_server_info_time_to_srtt, enable_connection_racing and
disable_disk_cache finch options.
==========

[Ryan Hamilton, 2017-04-17 02:13:50]

rch@chromium.org changed reviewers:
+ ianswett@google.com

[Ryan Hamilton, 2017-04-17 02:13:51]

ianswett: FYI if you're bored before you head out on vacation

[ianswett, 2017-04-17 02:39:47]

On 2017/04/17 02:13:51, Ryan Hamilton wrote:
> ianswett: FYI if you're bored before you head out on vacation

Thanks for the excellent simplification.  A few q's, but I think Cherie will
know the answers better than me, so once she's happy, LGTM.

[Ryan Hamilton, 2017-04-17 17:17:34]

rch@chromium.org changed reviewers:
+ jri@chromium.org

[Ryan Hamilton, 2017-04-17 17:17:42]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 17:18:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 17:21:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 17:21:20]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Jana, 2017-04-17 17:48:01]

lgtm

Thanks, Ryan!

[Ryan Hamilton, 2017-04-17 18:17:34]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 18:18:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 18:21:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 18:21:56]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ryan Hamilton, 2017-04-17 18:47:41]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 18:48:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 19:17:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 19:17:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[xunjieli, 2017-04-17 19:46:14]

On 2017/04/17 17:48:01, Jana wrote:
> lgtm
> 
> Thanks, Ryan!

This is great! I think this will be a step towards solving crbug.com/707953 ? Do
you want to attach this CL to that bug number?

[Ryan Hamilton, 2017-04-17 20:40:09]

On 2017/04/17 19:46:14, xunjieli wrote:
> On 2017/04/17 17:48:01, Jana wrote:
> > lgtm
> > 
> > Thanks, Ryan!
> 
> This is great! I think this will be a step towards solving crbug.com/707953 ?
Do
> you want to attach this CL to that bug number?

sure!

[Ryan Hamilton, 2017-04-17 20:40:25]

Description was changed from

==========
Remove the code to store and load QUIC server configs in the disk cache.

This includes the load_server_info_time_to_srtt, enable_connection_racing and
disable_disk_cache finch options.
==========

to

==========
Remove the code to store and load QUIC server configs in the disk cache.

This includes the load_server_info_time_to_srtt, enable_connection_racing and
disable_disk_cache finch options.

BUG=707953
==========

[Ryan Hamilton, 2017-04-17 20:49:12]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 20:49:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 20:52:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 20:52:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ryan Hamilton, 2017-04-17 21:03:25]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 21:03:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Hamilton, 2017-04-17 21:03:48]

rch@chromium.org changed reviewers:
+ jwd@chromium.org

[Ryan Hamilton, 2017-04-17 21:03:49]

jwd: histograms/OWNERS please

[commit-bot: I haz the power, 2017-04-17 22:06:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 22:06:51]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2017-04-18 21:12:09]

On 2017/04/17 21:03:49, Ryan Hamilton wrote:
> jwd: histograms/OWNERS please

jwd: ping

[Ryan Hamilton, 2017-04-18 23:32:19]

On 2017/04/18 21:12:09, Ryan Hamilton wrote:
> On 2017/04/17 21:03:49, Ryan Hamilton wrote:
> > jwd: histograms/OWNERS please
> 
> jwd: ping

Actually, I've moved the histograms into a stand-alone CL:

https://codereview.chromium.org/2827863002

I'll send you that instead.

[Ryan Hamilton, 2017-04-18 23:32:27]

rch@chromium.org changed reviewers:
- jwd@chromium.org

[Ryan Hamilton, 2017-04-18 23:32:32]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2017-04-18 23:32:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
ianswett@chromium.org, jri@chromium.org
Link to the patchset: https://codereview.chromium.org/2820573004/#ps200001
(title: "Do histograms in a different CL")

[commit-bot: I haz the power, 2017-04-18 23:34:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 23:43:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 23:43:05]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[Ryan Hamilton, 2017-04-18 23:53:46]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2017-04-18 23:53:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
ianswett@chromium.org, jri@chromium.org
Link to the patchset: https://codereview.chromium.org/2820573004/#ps220001
(title: "fix")

[commit-bot: I haz the power, 2017-04-18 23:54:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 01:03:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 01:03:16]

Failed to apply patch for
components/network_session_configurator/network_session_configurator.cc:
While running git apply --index -3 -p1;
  error: patch failed:
components/network_session_configurator/network_session_configurator.cc:301
  Falling back to three-way merge...
  Applied patch to
'components/network_session_configurator/network_session_configurator.cc' with
conflicts.
  U components/network_session_configurator/network_session_configurator.cc

Patch:      
components/network_session_configurator/network_session_configurator.cc
Index: components/network_session_configurator/network_session_configurator.cc
diff --git
a/components/network_session_configurator/network_session_configurator.cc
b/components/network_session_configurator/network_session_configurator.cc
index
e12cc1c1cccab92cdb3569d89fdcbaeb173c5cf6..525e9ba2d15c21f5ec3732d8f682ea247d7614ed
100644
--- a/components/network_session_configurator/network_session_configurator.cc
+++ b/components/network_session_configurator/network_session_configurator.cc
@@ -134,34 +134,12 @@ net::QuicTagVector GetQuicConnectionOptions(
   return net::ParseQuicConnectionOptions(it->second);
 }
 
-float GetQuicLoadServerInfoTimeoutSrttMultiplier(
-    const VariationParameters& quic_trial_params) {
-  double value;
-  if (base::StringToDouble(
-          GetVariationParam(quic_trial_params,
"load_server_info_time_to_srtt"),
-          &value)) {
-    return static_cast<float>(value);
-  }
-  return 0.0f;
-}
-
-bool ShouldQuicEnableConnectionRacing(
-    const VariationParameters& quic_trial_params) {
-  return base::LowerCaseEqualsASCII(
-      GetVariationParam(quic_trial_params, "enable_connection_racing"),
"true");
-}
-
 bool ShouldQuicEnableNonBlockingIO(
     const VariationParameters& quic_trial_params) {
   return base::LowerCaseEqualsASCII(
       GetVariationParam(quic_trial_params, "enable_non_blocking_io"), "true");
 }
 
-bool ShouldQuicDisableDiskCache(const VariationParameters& quic_trial_params) {
-  return base::LowerCaseEqualsASCII(
-      GetVariationParam(quic_trial_params, "disable_disk_cache"), "true");
-}
-
 bool ShouldForceHolBlocking(const VariationParameters& quic_trial_params) {
   return base::LowerCaseEqualsASCII(
       GetVariationParam(quic_trial_params, "force_hol_blocking"), "true");
@@ -301,18 +279,8 @@ void ConfigureQuicParams(base::StringPiece
quic_trial_group,
 
   if (params->enable_quic) {
     params->quic_delay_tcp_race = ShouldQuicDelayTcpRace(quic_trial_params);
-    float load_server_info_timeout_srtt_multiplier =
-        GetQuicLoadServerInfoTimeoutSrttMultiplier(quic_trial_params);
-    if (load_server_info_timeout_srtt_multiplier != 0) {
-      params->quic_load_server_info_timeout_srtt_multiplier =
-          load_server_info_timeout_srtt_multiplier;
-    }
-    params->quic_enable_connection_racing =
-        ShouldQuicEnableConnectionRacing(quic_trial_params);
     params->quic_enable_non_blocking_io =
         ShouldQuicEnableNonBlockingIO(quic_trial_params);
-    params->quic_disable_disk_cache =
-        ShouldQuicDisableDiskCache(quic_trial_params);
     params->quic_force_hol_blocking =
ShouldForceHolBlocking(quic_trial_params);
     params->quic_connection_options =
         GetQuicConnectionOptions(quic_trial_params);

[Ryan Hamilton, 2017-04-19 01:29:19]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2017-04-19 01:29:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
ianswett@chromium.org, jri@chromium.org
Link to the patchset: https://codereview.chromium.org/2820573004/#ps240001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-19 01:29:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 02:46:11]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1492565359475870,
"parent_rev": "2ca07e8beb876773a64f9e7187847705f378199f", "commit_rev":
"8db55262b68de5ccad8f4421afb5328a89ff3bad"}

[commit-bot: I haz the power, 2017-04-19 02:46:27]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1492565359475870,
"parent_rev": "9fca3869dc3c539cecdea9e7934499c0ac493b9e", "commit_rev":
"6f3dd74bddb23a2e5e74ba6976f02f94d76d2dda"}

[commit-bot: I haz the power, 2017-04-19 02:46:37]

Description was changed from

==========
Remove the code to store and load QUIC server configs in the disk cache.

This includes the load_server_info_time_to_srtt, enable_connection_racing and
disable_disk_cache finch options.

BUG=707953
==========

to

==========
Remove the code to store and load QUIC server configs in the disk cache.

This includes the load_server_info_time_to_srtt, enable_connection_racing and
disable_disk_cache finch options.

BUG=707953

Review-Url: https://codereview.chromium.org/2820573004
Cr-Commit-Position: refs/heads/master@{#465474}
Committed:
https://chromium.googlesource.com/chromium/src/+/6f3dd74bddb23a2e5e74ba6976f0...
==========

[commit-bot: I haz the power, 2017-04-19 02:46:39]

Committed patchset #13 (id:240001) as
https://chromium.googlesource.com/chromium/src/+/6f3dd74bddb23a2e5e74ba6976f0...

[aboxhall, 2017-04-19 05:45:23]

A revert of this CL (patchset #13 id:240001) has been created in
https://codereview.chromium.org/2821053004/ by aboxhall@chromium.org.

The reason for reverting is: Lots of MSan failures:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chrom....

[Ryan Hamilton, 2017-04-19 13:59:55]

Description was changed from

==========
Remove the code to store and load QUIC server configs in the disk cache.

This includes the load_server_info_time_to_srtt, enable_connection_racing and
disable_disk_cache finch options.

BUG=707953

Review-Url: https://codereview.chromium.org/2820573004
Cr-Commit-Position: refs/heads/master@{#465474}
Committed:
https://chromium.googlesource.com/chromium/src/+/6f3dd74bddb23a2e5e74ba6976f0...
==========

to

==========
Remove the code to store and load QUIC server configs in the disk cache.

This includes the load_server_info_time_to_srtt, enable_connection_racing and
disable_disk_cache finch options.

BUG=707953

Review-Url: https://codereview.chromium.org/2820573004
Cr-Commit-Position: refs/heads/master@{#465474}
Committed:
https://chromium.googlesource.com/chromium/src/+/6f3dd74bddb23a2e5e74ba6976f0...
==========

[Ryan Hamilton, 2017-04-19 14:07:40]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2017-04-19 14:07:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
ianswett@chromium.org, jri@chromium.org
Link to the patchset: https://codereview.chromium.org/2820573004/#ps260001
(title: "Fix")

[commit-bot: I haz the power, 2017-04-19 14:08:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 15:22:39]

CQ is committing da patch.

Bot data: {"patchset_id": 260001, "attempt_start_ts": 1492610860433820,
"parent_rev": "c8eaca63b6cd1d78854e493bae4eb18ccaecfcc2", "commit_rev":
"431dd44543668f59e341aaf350f1370690ee9b35"}

[commit-bot: I haz the power, 2017-04-19 15:22:47]

Description was changed from

==========
Remove the code to store and load QUIC server configs in the disk cache.

This includes the load_server_info_time_to_srtt, enable_connection_racing and
disable_disk_cache finch options.

BUG=707953

Review-Url: https://codereview.chromium.org/2820573004
Cr-Commit-Position: refs/heads/master@{#465474}
Committed:
https://chromium.googlesource.com/chromium/src/+/6f3dd74bddb23a2e5e74ba6976f0...
==========

to

==========
Remove the code to store and load QUIC server configs in the disk cache.

This includes the load_server_info_time_to_srtt, enable_connection_racing and
disable_disk_cache finch options.

BUG=707953

Review-Url: https://codereview.chromium.org/2820573004
Cr-Original-Commit-Position: refs/heads/master@{#465474}
Committed:
https://chromium.googlesource.com/chromium/src/+/6f3dd74bddb23a2e5e74ba6976f0...
Review-Url: https://codereview.chromium.org/2820573004
Cr-Commit-Position: refs/heads/master@{#465613}
Committed:
https://chromium.googlesource.com/chromium/src/+/431dd44543668f59e341aaf350f1...
==========

[commit-bot: I haz the power, 2017-04-19 15:22:50]

Committed patchset #14 (id:260001) as
https://chromium.googlesource.com/chromium/src/+/431dd44543668f59e341aaf350f1...