Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: components/network_session_configurator/network_session_configurator.cc

Issue 2830563002: Remove the unused "Disable non-blocking IO" QUIC experiment code. (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/network_session_configurator/network_session_configurator_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/network_session_configurator/network_session_configurator.h " 5 #include "components/network_session_configurator/network_session_configurator.h "
6 6
7 #include <map> 7 #include <map>
8 #include <unordered_set> 8 #include <unordered_set>
9 9
10 #include "base/metrics/field_trial.h" 10 #include "base/metrics/field_trial.h"
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 const VariationParameters& quic_trial_params) { 127 const VariationParameters& quic_trial_params) {
128 VariationParameters::const_iterator it = 128 VariationParameters::const_iterator it =
129 quic_trial_params.find("connection_options"); 129 quic_trial_params.find("connection_options");
130 if (it == quic_trial_params.end()) { 130 if (it == quic_trial_params.end()) {
131 return net::QuicTagVector(); 131 return net::QuicTagVector();
132 } 132 }
133 133
134 return net::ParseQuicConnectionOptions(it->second); 134 return net::ParseQuicConnectionOptions(it->second);
135 } 135 }
136 136
137 bool ShouldQuicEnableNonBlockingIO(
138 const VariationParameters& quic_trial_params) {
139 return base::LowerCaseEqualsASCII(
140 GetVariationParam(quic_trial_params, "enable_non_blocking_io"), "true");
141 }
142
143 bool ShouldForceHolBlocking(const VariationParameters& quic_trial_params) { 137 bool ShouldForceHolBlocking(const VariationParameters& quic_trial_params) {
144 return base::LowerCaseEqualsASCII( 138 return base::LowerCaseEqualsASCII(
145 GetVariationParam(quic_trial_params, "force_hol_blocking"), "true"); 139 GetVariationParam(quic_trial_params, "force_hol_blocking"), "true");
146 } 140 }
147 141
148 bool ShouldQuicCloseSessionsOnIpChange( 142 bool ShouldQuicCloseSessionsOnIpChange(
149 const VariationParameters& quic_trial_params) { 143 const VariationParameters& quic_trial_params) {
150 return base::LowerCaseEqualsASCII( 144 return base::LowerCaseEqualsASCII(
151 GetVariationParam(quic_trial_params, "close_sessions_on_ip_change"), 145 GetVariationParam(quic_trial_params, "close_sessions_on_ip_change"),
152 "true"); 146 "true");
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 params->mark_quic_broken_when_network_blackholes = 260 params->mark_quic_broken_when_network_blackholes =
267 ShouldMarkQuicBrokenWhenNetworkBlackholes(quic_trial_params); 261 ShouldMarkQuicBrokenWhenNetworkBlackholes(quic_trial_params);
268 262
269 params->enable_server_push_cancellation = 263 params->enable_server_push_cancellation =
270 ShouldEnableServerPushCancelation(quic_trial_params); 264 ShouldEnableServerPushCancelation(quic_trial_params);
271 265
272 params->retry_without_alt_svc_on_quic_errors = 266 params->retry_without_alt_svc_on_quic_errors =
273 ShouldRetryWithoutAltSvcOnQuicErrors(quic_trial_params); 267 ShouldRetryWithoutAltSvcOnQuicErrors(quic_trial_params);
274 268
275 if (params->enable_quic) { 269 if (params->enable_quic) {
276 params->quic_enable_non_blocking_io =
277 ShouldQuicEnableNonBlockingIO(quic_trial_params);
278 params->quic_force_hol_blocking = ShouldForceHolBlocking(quic_trial_params); 270 params->quic_force_hol_blocking = ShouldForceHolBlocking(quic_trial_params);
279 params->quic_connection_options = 271 params->quic_connection_options =
280 GetQuicConnectionOptions(quic_trial_params); 272 GetQuicConnectionOptions(quic_trial_params);
281 params->quic_close_sessions_on_ip_change = 273 params->quic_close_sessions_on_ip_change =
282 ShouldQuicCloseSessionsOnIpChange(quic_trial_params); 274 ShouldQuicCloseSessionsOnIpChange(quic_trial_params);
283 int idle_connection_timeout_seconds = 275 int idle_connection_timeout_seconds =
284 GetQuicIdleConnectionTimeoutSeconds(quic_trial_params); 276 GetQuicIdleConnectionTimeoutSeconds(quic_trial_params);
285 if (idle_connection_timeout_seconds != 0) { 277 if (idle_connection_timeout_seconds != 0) {
286 params->quic_idle_connection_timeout_seconds = 278 params->quic_idle_connection_timeout_seconds =
287 idle_connection_timeout_seconds; 279 idle_connection_timeout_seconds;
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 ConfigureTCPFastOpenParams(tfo_trial_group, params); 371 ConfigureTCPFastOpenParams(tfo_trial_group, params);
380 372
381 std::map<std::string, std::string> proxy_preconnects_trial_params; 373 std::map<std::string, std::string> proxy_preconnects_trial_params;
382 variations::GetVariationParams("NetProxyPreconnects", 374 variations::GetVariationParams("NetProxyPreconnects",
383 &proxy_preconnects_trial_params); 375 &proxy_preconnects_trial_params);
384 ConfigureOptimizePreconnectsToProxiesParams(proxy_preconnects_trial_params, 376 ConfigureOptimizePreconnectsToProxiesParams(proxy_preconnects_trial_params,
385 params); 377 params);
386 } 378 }
387 379
388 } // namespace network_session_configurator 380 } // namespace network_session_configurator
OLDNEW
« no previous file with comments | « no previous file | components/network_session_configurator/network_session_configurator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698