Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2253753002: Always use NonBlocking IO for UDP sockets on Windows. (Closed)

Created:
4 years, 4 months ago by Ryan Hamilton
Modified:
3 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Always use NonBlocking IO for UDP sockets on Windows. QUIC experiments demonstrated that this was at least as performant as overlapped IO. BUG=600045

Patch Set 1 #

Patch Set 2 : Finish #

Patch Set 3 : socket_host_udp_unittest.cc #

Patch Set 4 : More #

Patch Set 5 : Rebase #

Patch Set 6 : media #

Patch Set 7 : Rebase #

Patch Set 8 : content/browser/renderer_host/p2p/ #

Patch Set 9 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -392 lines) Patch
M content/browser/renderer_host/p2p/socket_host_udp.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp_unittest.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -2 lines 0 comments Download
M media/cast/net/udp_transport.h View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M media/cast/net/udp_transport.cc View 1 2 3 4 5 3 chunks +0 lines, -17 lines 0 comments Download
M net/dns/address_sorter_posix_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M net/dns/mock_mdns_socket_factory.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2 lines 0 comments Download
M net/socket/datagram_socket.h View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M net/socket/fuzzed_datagram_client_socket.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/fuzzed_datagram_client_socket.cc View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M net/socket/socket_test_util.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/socket_test_util.cc View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M net/socket/udp_client_socket.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/udp_client_socket.cc View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M net/socket/udp_server_socket.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/udp_server_socket.cc View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M net/socket/udp_socket_perftest.cc View 1 2 3 4 5 chunks +3 lines, -18 lines 0 comments Download
M net/socket/udp_socket_unittest.cc View 1 2 3 4 5 chunks +2 lines, -19 lines 0 comments Download
M net/socket/udp_socket_win.h View 1 2 3 4 2 chunks +0 lines, -17 lines 0 comments Download
M net/socket/udp_socket_win.cc View 1 2 3 4 9 chunks +4 lines, -280 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 37 (30 generated)
Ryan Hamilton
xjz: media OWNERS, please zhongyi: PTAL
3 years, 8 months ago (2017-04-17 19:29:09 UTC) #16
Ryan Hamilton
sergeyu: content/browser/renderer_host/p2p/, please hubbe: media/cast/net, please
3 years, 8 months ago (2017-04-18 02:54:29 UTC) #28
Sergey Ulanov
lgtm
3 years, 8 months ago (2017-04-18 17:21:26 UTC) #31
hubbe
media/cast/* LGTM
3 years, 8 months ago (2017-04-18 17:36:42 UTC) #32
Zhongyi Shi
lgtm
3 years, 8 months ago (2017-04-18 18:57:32 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253753002/140001
3 years, 8 months ago (2017-04-18 18:58:13 UTC) #35
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 21:24:39 UTC) #37
Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

Powered by Google App Engine
This is Rietveld 408576698