Milo buildbot: Add in the rest of the blame/commits information.

Milo buildbot: Add in the rest of the blame/commits information.

Also:
* Make revision into a link (was string)
* Add CommitTime to Commit

BUG=686874
Review-Url: https://codereview.chromium.org/2823413002
Committed: https://github.com/luci/luci-go/commit/49eca9e65f27839752cf6d678ad33e860f3fdfc1

[Ryan Tseng, 2017-04-18 22:22:28]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 22:22:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 22:33:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 22:33:54]

Dry run: This issue passed the CQ dry run.

[hinoka, 2017-04-18 23:29:25]

Description was changed from

==========
Milo buildbot: Add in the rest of the blame/commits information.

BUG=686874
==========

to

==========
Milo buildbot: Add in the rest of the blame/commits information.

Also:
* Make revision into a link (was string)
* Add CommitTime to Commit

BUG=686874
==========

[hinoka, 2017-04-18 23:29:25]

hinoka@chromium.org changed reviewers:
+ nodir@chromium.org

[hinoka, 2017-04-18 23:29:36]

hinoka@chromium.org changed reviewers:
+ hinoka@chromium.org

[hinoka, 2017-04-18 23:29:37]

ptal, demo
https://1680-8fa48d3-tainted-hinoka-blame-dot-luci-milo-dev.appspot.com/build...

[nodir, 2017-04-19 18:37:48]

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/backend/git/...
File milo/appengine/backend/git/gitiles.go (right):

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/backend/git/...
milo/appengine/backend/git/gitiles.go:68: if !strings.HasSuffix(u.Host,
"googlesource.com") {
it must be ".googlesource.com"
otherwise one may use hackedgooglesource.com

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/buildbot/bui...
File milo/appengine/buildbot/build.go (right):

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/buildbot/bui...
milo/appengine/buildbot/build.go:383: type bbFile struct {
what is this? i don't see its usage

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/buildbot/str...
File milo/appengine/buildbot/structs.go (right):

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/buildbot/str...
milo/appengine/buildbot/structs.go:343: if fn, ok := f.(string); ok {
i think a type-switch would be cleaner here

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/buildbot/str...
milo/appengine/buildbot/structs.go:349: files[i] = fmt.Sprintf("%#v", f)
i think if a user sees such as string, they would perceive it as a sloppy bug.
WDYT about logging an error/warning and not omitting?

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/buildbucket/...
File
milo/appengine/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.json
(right):

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/buildbucket/...
milo/appengine/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.json:36:
"Revision": {
this does not look right. Shouldn't this be nil?

also I think all these fields used in expectation files should be marked
omitempty

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/frontend/tem...
File milo/appengine/frontend/templates/pages/build.html (right):

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/frontend/tem...
milo/appengine/frontend/templates/pages/build.html:268: <td><b>
shouldn't we use CSS instead of <b> here and in files?

[nodir, 2017-04-20 03:24:08]

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/buildbot/str...
File milo/appengine/buildbot/structs.go (right):

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/buildbot/str...
milo/appengine/buildbot/structs.go:349: files[i] = fmt.Sprintf("%#v", f)
On 2017/04/19 18:37:48, nodir wrote:
> i think if a user sees such as string, they would perceive it as a sloppy bug.
> WDYT about logging an error/warning and not omitting?

I meant omitting

[Ryan Tseng, 2017-04-20 21:57:07]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 21:57:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 22:01:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 22:01:02]

Dry run: Try jobs failed on following builders:
  Luci-go Linux Trusty 32-on-64 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/35a63036af232710)

[Ryan Tseng, 2017-04-20 22:03:47]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 22:03:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hinoka, 2017-04-20 22:09:44]

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/backend/git/...
File milo/appengine/backend/git/gitiles.go (right):

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/backend/git/...
milo/appengine/backend/git/gitiles.go:68: if !strings.HasSuffix(u.Host,
"googlesource.com") {
On 2017/04/19 18:37:48, nodir wrote:
> it must be ".googlesource.com"
> otherwise one may use http://hackedgooglesource.com

Done.

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/buildbot/bui...
File milo/appengine/buildbot/build.go (right):

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/buildbot/bui...
milo/appengine/buildbot/build.go:383: type bbFile struct {
On 2017/04/19 18:37:48, nodir wrote:
> what is this? i don't see its usage

Oops, this wasn't supposed to be here.

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/buildbot/str...
File milo/appengine/buildbot/structs.go (right):

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/buildbot/str...
milo/appengine/buildbot/structs.go:343: if fn, ok := f.(string); ok {
On 2017/04/19 18:37:48, nodir wrote:
> i think a type-switch would be cleaner here

Done.

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/buildbot/str...
milo/appengine/buildbot/structs.go:349: files[i] = fmt.Sprintf("%#v", f)
On 2017/04/20 03:24:08, nodir wrote:
> On 2017/04/19 18:37:48, nodir wrote:
> > i think if a user sees such as string, they would perceive it as a sloppy
bug.
> > WDYT about logging an error/warning and not omitting?
> 
> I meant omitting

Done.  It just omits it without logging because I don't want to pass the context
into this function.  The context has no other use in here and it would just
otherwise complicate things.

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/buildbucket/...
File
milo/appengine/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.json
(right):

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/buildbucket/...
milo/appengine/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.json:36:
"Revision": {
On 2017/04/19 18:37:48, nodir wrote:
> this does not look right. Shouldn't this be nil?
> 
> also I think all these fields used in expectation files should be marked
> omitempty

Done.

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/frontend/tem...
File milo/appengine/frontend/templates/pages/build.html (right):

https://codereview.chromium.org/2823413002/diff/1/milo/appengine/frontend/tem...
milo/appengine/frontend/templates/pages/build.html:268: <td><b>
On 2017/04/19 18:37:48, nodir wrote:
> shouldn't we use CSS instead of <b> here and in files?

We could do that, <b> was because buildbot did it and I copied it over.

[commit-bot: I haz the power, 2017-04-20 22:10:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 22:10:45]

Dry run: This issue passed the CQ dry run.

[nodir, 2017-04-21 04:41:28]

lgtm

https://codereview.chromium.org/2823413002/diff/40001/milo/appengine/frontend...
File milo/appengine/frontend/templates/pages/build.html (right):

https://codereview.chromium.org/2823413002/diff/40001/milo/appengine/frontend...
milo/appengine/frontend/templates/pages/build.html:301: <li><b>{{ . }}</b></li>
Here too

[Ryan Tseng, 2017-04-21 17:02:45]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 17:02:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 17:09:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 17:09:58]

Dry run: This issue passed the CQ dry run.

[hinoka, 2017-04-21 17:38:00]

https://codereview.chromium.org/2823413002/diff/40001/milo/appengine/frontend...
File milo/appengine/frontend/templates/pages/build.html (right):

https://codereview.chromium.org/2823413002/diff/40001/milo/appengine/frontend...
milo/appengine/frontend/templates/pages/build.html:301: <li><b>{{ . }}</b></li>
On 2017/04/21 04:41:28, nodir wrote:
> Here too

Done.

[hinoka, 2017-04-21 17:38:04]

The CQ bit was checked by hinoka@chromium.org

[hinoka, 2017-04-21 17:38:05]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2823413002/#ps60001
(title: "Review")

[commit-bot: I haz the power, 2017-04-21 17:38:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 17:45:28]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492796284616920,
"parent_rev": "9fb9880d65325cef1fd8ff4099a1de27b4bf684e", "commit_rev":
"49eca9e65f27839752cf6d678ad33e860f3fdfc1"}

[commit-bot: I haz the power, 2017-04-21 17:45:31]

Description was changed from

==========
Milo buildbot: Add in the rest of the blame/commits information.

Also:
* Make revision into a link (was string)
* Add CommitTime to Commit

BUG=686874
==========

to

==========
Milo buildbot: Add in the rest of the blame/commits information.

Also:
* Make revision into a link (was string)
* Add CommitTime to Commit

BUG=686874

Review-Url: https://codereview.chromium.org/2823413002
Committed:
https://github.com/luci/luci-go/commit/49eca9e65f27839752cf6d678ad33e860f3fdfc1
==========

[commit-bot: I haz the power, 2017-04-21 17:45:33]

Committed patchset #4 (id:60001) as
https://github.com/luci/luci-go/commit/49eca9e65f27839752cf6d678ad33e860f3fdfc1