| Index: milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html
|
| diff --git a/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html b/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html
|
| index bbfbbb2092652649d38c1a1c16ba097d0d9b015a..28a3d928ef239afe0d712c78e6a17afa1359c023 100644
|
| --- a/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html
|
| +++ b/milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html
|
| @@ -67,7 +67,7 @@
|
|
|
|
|
|
|
| - <tr><td class="left">Got Revision</td><td>bfdee36d31a624d330b60b481fc26d10dff81b97</td></tr>
|
| + <tr><td class="left">Got Revision</td><td><a href="https://chromium.googlesource.com/chromium/src/+/bfdee36d31a624d330b60b481fc26d10dff81b97">bfdee36d31a624d330b60b481fc26d10dff81b97</a></td></tr>
|
|
|
|
|
|
|
| @@ -695,37 +695,558 @@
|
|
|
| <li>
|
| <h3>Remove type converters for ui::Event.</h3>
|
| + <table class="info">
|
| + <tbody>
|
| + <tr>
|
| + <td class="left">Changed by</td>
|
| + <td class="value">
|
| +
|
| + moshayedi<span style="display:none">ohnoyoudont</span>@chromium.org
|
| + </td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Changed at</td>
|
| + <td class="value"><span class="local-time" data-timestamp="1465417408000">Wednesday, 08-Jun-16 13:23:28 PDT</span></td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Repository</td>
|
| + <td class="value">https://chromium.googlesource.com/chromium/src</td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Branch</td>
|
| + <td class="value"></td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Revision</td>
|
| + <td class="value"><a href="https://chromium.googlesource.com/chromium/src/+/74b54c510611ebaa8479d004a6878abe96e372d3">74b54c510611ebaa8479d004a6878abe96e372d3</a></td>
|
| + </tr>
|
| + </tbody>
|
| + </table>
|
| +
|
| +
|
| + <h3>Comments</h3>
|
| + <pre class="comments">Remove type converters for ui::Event.
|
| +
|
| +We are using struct traits for serializing/deserializing ui::Event and don't
|
| +need type converters anymore.
|
| +
|
| +BUG=578206
|
| +
|
| +Review-Url: https://codereview.chromium.org/2048633004
|
| +Cr-Commit-Position: refs/heads/master@{#398655}
|
| +</pre>
|
|
|
| +
|
| +
|
| + <h3 class="files">Changed files</h3>
|
| + <ul class="alternating">
|
| +
|
| + <li class="file">ash/mus/BUILD.gn</li>
|
| +
|
| + <li class="file">ash/mus/frame/non_client_frame_view_mash.cc</li>
|
| +
|
| + <li class="file">ash/mus/window_manager_application.cc</li>
|
| +
|
| + <li class="file">ash/sysui/BUILD.gn</li>
|
| +
|
| + <li class="file">components/mus/public/cpp/BUILD.gn</li>
|
| +
|
| + <li class="file">components/mus/public/cpp/lib/window_tree_client.cc</li>
|
| +
|
| + <li class="file">components/mus/public/cpp/tests/BUILD.gn</li>
|
| +
|
| + <li class="file">components/mus/public/cpp/tests/window_tree_client_private.cc</li>
|
| +
|
| + <li class="file">components/mus/public/cpp/tests/window_tree_client_unittest.cc</li>
|
| +
|
| + <li class="file">components/mus/ws/BUILD.gn</li>
|
| +
|
| + <li class="file">components/mus/ws/event_dispatcher.cc</li>
|
| +
|
| + <li class="file">components/mus/ws/event_matcher.cc</li>
|
| +
|
| + <li class="file">components/mus/ws/platform_display.cc</li>
|
| +
|
| + <li class="file">components/mus/ws/window_server.cc</li>
|
| +
|
| + <li class="file">components/mus/ws/window_tree.cc</li>
|
| +
|
| + <li class="file">content/renderer/mus/BUILD.gn</li>
|
| +
|
| + <li class="file">content/renderer/mus/compositor_mus_connection.cc</li>
|
| +
|
| + <li class="file">ui/events/mojo/BUILD.gn</li>
|
| +
|
| + <li class="file">ui/events/mojo/input_events_type_converters.cc</li>
|
| +
|
| + <li class="file">ui/events/mojo/input_events_type_converters.h</li>
|
| +
|
| + <li class="file">ui/events/mojo/mojo_extended_key_event_data.cc</li>
|
| +
|
| + <li class="file">ui/events/mojo/mojo_extended_key_event_data.h</li>
|
| +
|
| + <li class="file">ui/events/mojo/mojo_input_events_export.h</li>
|
| +
|
| + <li class="file">ui/views/mus/BUILD.gn</li>
|
| +
|
| + </ul>
|
| +
|
| +
|
| </li>
|
|
|
| <li>
|
| <h3>StructTraits optimizations</h3>
|
| + <table class="info">
|
| + <tbody>
|
| + <tr>
|
| + <td class="left">Changed by</td>
|
| + <td class="value">
|
| +
|
| + fsamuel<span style="display:none">ohnoyoudont</span>@chromium.org
|
| + </td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Changed at</td>
|
| + <td class="value"><span class="local-time" data-timestamp="1465417532000">Wednesday, 08-Jun-16 13:25:32 PDT</span></td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Repository</td>
|
| + <td class="value">https://chromium.googlesource.com/chromium/src</td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Branch</td>
|
| + <td class="value"></td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Revision</td>
|
| + <td class="value"><a href="https://chromium.googlesource.com/chromium/src/+/605998f30d05bb8d323542c1039e64e1afce696b">605998f30d05bb8d323542c1039e64e1afce696b</a></td>
|
| + </tr>
|
| + </tbody>
|
| + </table>
|
| +
|
|
|
| + <h3>Comments</h3>
|
| + <pre class="comments">StructTraits optimizations
|
| +
|
| +Pass more things by const reference and read directly into output.
|
| +
|
| +BUG=611802
|
| +CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
|
| +
|
| +Review-Url: https://codereview.chromium.org/2047963004
|
| +Cr-Commit-Position: refs/heads/master@{#398656}
|
| +</pre>
|
| +
|
| +
|
| +
|
| + <h3 class="files">Changed files</h3>
|
| + <ul class="alternating">
|
| +
|
| + <li class="file">cc/ipc/returned_resource_struct_traits.h</li>
|
| +
|
| + <li class="file">cc/ipc/selection_struct_traits.h</li>
|
| +
|
| + <li class="file">cc/ipc/shared_quad_state_struct_traits.h</li>
|
| +
|
| + <li class="file">cc/ipc/transferable_resource_struct_traits.h</li>
|
| +
|
| + <li class="file">gpu/ipc/common/mailbox_holder_struct_traits.h</li>
|
| +
|
| + </ul>
|
| +
|
| +
|
| </li>
|
|
|
| <li>
|
| <h3>Manual refactor to enum-based WaitableEvent for remaining _win files</h3>
|
| + <table class="info">
|
| + <tbody>
|
| + <tr>
|
| + <td class="left">Changed by</td>
|
| + <td class="value">
|
| +
|
| + gab<span style="display:none">ohnoyoudont</span>@chromium.org
|
| + </td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Changed at</td>
|
| + <td class="value"><span class="local-time" data-timestamp="1465417533000">Wednesday, 08-Jun-16 13:25:33 PDT</span></td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Repository</td>
|
| + <td class="value">https://chromium.googlesource.com/chromium/src</td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Branch</td>
|
| + <td class="value"></td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Revision</td>
|
| + <td class="value"><a href="https://chromium.googlesource.com/chromium/src/+/7c19b196f653ec0e2b3aab703611231efc04cb2a">7c19b196f653ec0e2b3aab703611231efc04cb2a</a></td>
|
| + </tr>
|
| + </tbody>
|
| + </table>
|
| +
|
| +
|
| + <h3>Comments</h3>
|
| + <pre class="comments">Manual refactor to enum-based WaitableEvent for remaining _win files
|
| +
|
| +BUG=612843
|
| +R=fdoray@chromium.org
|
| +TBR=danakj@chromium.org
|
| +(Francois please fact check me, I'm TBRing dana for otherwise mechanical change)
|
| +
|
| +Review-Url: https://codereview.chromium.org/2047163003
|
| +Cr-Commit-Position: refs/heads/master@{#398657}
|
| +</pre>
|
| +
|
| +
|
|
|
| + <h3 class="files">Changed files</h3>
|
| + <ul class="alternating">
|
| +
|
| + <li class="file">base/sync_socket_win.cc</li>
|
| +
|
| + <li class="file">chrome/browser/chrome_select_file_dialog_factory_win.cc</li>
|
| +
|
| + <li class="file">chrome/browser/password_manager/password_store_win_unittest.cc</li>
|
| +
|
| + <li class="file">components/policy/core/common/policy_loader_win.cc</li>
|
| +
|
| + <li class="file">net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc</li>
|
| +
|
| + <li class="file">net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc</li>
|
| +
|
| + </ul>
|
| +
|
| +
|
| </li>
|
|
|
| <li>
|
| <h3>Add role lists to ChromeVox.</h3>
|
| + <table class="info">
|
| + <tbody>
|
| + <tr>
|
| + <td class="left">Changed by</td>
|
| + <td class="value">
|
| +
|
| + dtseng<span style="display:none">ohnoyoudont</span>@chromium.org
|
| + </td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Changed at</td>
|
| + <td class="value"><span class="local-time" data-timestamp="1465417639000">Wednesday, 08-Jun-16 13:27:19 PDT</span></td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Repository</td>
|
| + <td class="value">https://chromium.googlesource.com/chromium/src</td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Branch</td>
|
| + <td class="value"></td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Revision</td>
|
| + <td class="value"><a href="https://chromium.googlesource.com/chromium/src/+/b0b4c0099b04f00b117595a762d09eb3e692f944">b0b4c0099b04f00b117595a762d09eb3e692f944</a></td>
|
| + </tr>
|
| + </tbody>
|
| + </table>
|
| +
|
| +
|
| + <h3>Comments</h3>
|
| + <pre class="comments">Add role lists to ChromeVox.
|
| +
|
| +- add lists for forms, headings, landmarks, links, and tables.
|
| +- fix some focusing issues with menus
|
| +
|
| +BUG=617670
|
| +
|
| +CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
|
| +
|
| +Review-Url: https://codereview.chromium.org/2042083002
|
| +Cr-Commit-Position: refs/heads/master@{#398658}
|
| +</pre>
|
| +
|
| +
|
| +
|
| + <h3 class="files">Changed files</h3>
|
| + <ul class="alternating">
|
| +
|
| + <li class="file">chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json</li>
|
| +
|
| + <li class="file">chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js</li>
|
| +
|
| + <li class="file">chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js</li>
|
| +
|
| + <li class="file">chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js</li>
|
| +
|
| + <li class="file">chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd</li>
|
| +
|
| + </ul>
|
|
|
| +
|
| </li>
|
|
|
| <li>
|
| <h3>Add DisableIf annotation to EME test</h3>
|
| + <table class="info">
|
| + <tbody>
|
| + <tr>
|
| + <td class="left">Changed by</td>
|
| + <td class="value">
|
| +
|
| + yolandyan<span style="display:none">ohnoyoudont</span>@google.com
|
| + </td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Changed at</td>
|
| + <td class="value"><span class="local-time" data-timestamp="1465417829000">Wednesday, 08-Jun-16 13:30:29 PDT</span></td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Repository</td>
|
| + <td class="value">https://chromium.googlesource.com/chromium/src</td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Branch</td>
|
| + <td class="value"></td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Revision</td>
|
| + <td class="value"><a href="https://chromium.googlesource.com/chromium/src/+/ea1675fb67d48828efb8c6b168582aa9f33388a2">ea1675fb67d48828efb8c6b168582aa9f33388a2</a></td>
|
| + </tr>
|
| + </tbody>
|
| + </table>
|
| +
|
| +
|
| + <h3>Comments</h3>
|
| + <pre class="comments">Add DisableIf annotation to EME test
|
| +
|
| +EME test does not pass on AOSP Android, therefore, add DisableIf annotation to
|
| +it (from BaseInstrumentationTestRunner)
|
| +
|
| +Reorganized BaseInstrumentationTestRunner so it doesn't include anything
|
| +unrelated to WebViewLayout Testing.
|
| +
|
| +BUG=607350
|
| +
|
| +Review-Url: https://codereview.chromium.org/1952573002
|
| +Cr-Commit-Position: refs/heads/master@{#398659}
|
| +</pre>
|
| +
|
| +
|
|
|
| + <h3 class="files">Changed files</h3>
|
| + <ul class="alternating">
|
| +
|
| + <li class="file">android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java</li>
|
| +
|
| + <li class="file">android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTestRunner.java</li>
|
| +
|
| + <li class="file">base/test/android/javatests/src/org/chromium/base/test/util/DisableIf.java</li>
|
| +
|
| + <li class="file">base/test/android/javatests/src/org/chromium/base/test/util/DisableIfSkipCheck.java</li>
|
| +
|
| + </ul>
|
| +
|
| +
|
| </li>
|
|
|
| <li>
|
| <h3>Revert of service worker: Don't control a subframe of an insecure context (patchset #21 id:440001 of https://codereview.chromium.org/2009453002/ )</h3>
|
| + <table class="info">
|
| + <tbody>
|
| + <tr>
|
| + <td class="left">Changed by</td>
|
| + <td class="value">
|
| +
|
| + dcheng<span style="display:none">ohnoyoudont</span>@chromium.org
|
| + </td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Changed at</td>
|
| + <td class="value"><span class="local-time" data-timestamp="1465417954000">Wednesday, 08-Jun-16 13:32:34 PDT</span></td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Repository</td>
|
| + <td class="value">https://chromium.googlesource.com/chromium/src</td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Branch</td>
|
| + <td class="value"></td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Revision</td>
|
| + <td class="value"><a href="https://chromium.googlesource.com/chromium/src/+/c363d41a6001cb7b27789484702d23fa4572a918">c363d41a6001cb7b27789484702d23fa4572a918</a></td>
|
| + </tr>
|
| + </tbody>
|
| + </table>
|
| +
|
|
|
| + <h3>Comments</h3>
|
| + <pre class="comments">Revert of service worker: Don't control a subframe of an insecure context (patchset #21 id:440001 of https://codereview.chromium.org/2009453002/ )
|
| +
|
| +Reason for revert:
|
| +ServiceWorkerProviderHost::SetControllerVersionAttribute CHECK is firing in release builds: https://crbug.com/618365
|
| +
|
| +Original issue's description:
|
| +> service worker: Don't control a subframe of an insecure context
|
| +>
|
| +> We must check isSecureContext when creating the network provider to
|
| +> adhere to https://w3c.github.io/webappsec/specs/pow
|
| +...skip...
|
| +ux:linux_site_isolation
|
| +>
|
| +> Committed: https://crrev.com/59a2e54eeb0e61971a0c27c44c54dd0c30b5d06d
|
| +> Cr-Commit-Position: refs/heads/master@{#398229}
|
| +
|
| +TBR=alexmos@chromium.org,clamy@chromium.org,horo@chromium.org,jww@chromium.org,kinuko@chromium.org,lazyboy@chromium.org,rdevlin.cronin@chromium.org,falken@chromium.org
|
| +# Not skipping CQ checks because original CL landed more than 1 days ago.
|
| +BUG=607543
|
| +
|
| +Review-Url: https://codereview.chromium.org/2055433002
|
| +Cr-Commit-Position: refs/heads/master@{#398660}
|
| +</pre>
|
| +
|
| +
|
| +
|
| + <h3 class="files">Changed files</h3>
|
| + <ul class="alternating">
|
| +
|
| + <li class="file">chrome/browser/chrome_content_browser_client.cc</li>
|
| +
|
| + <li class="file">chrome/browser/chrome_content_browser_client.h</li>
|
| +
|
| + <li class="file">chrome/browser/extensions/service_worker_apitest.cc</li>
|
| +
|
| + <li class="file">content/browser/service_worker/service_worker_browsertest.cc</li>
|
| +
|
| + <li class="file">content/browser/service_worker/service_worker_context_core.cc</li>
|
| +
|
| + <li class="file">content/browser/service_worker/service_worker_context_request_handler_unittest.cc</li>
|
| +
|
| + <li class="file">content/browser/service_worker/service_worker_context_unittest.cc</li>
|
| +
|
| + <li class="file">content/browser/service_worker/service_worker_controllee_request_handler.cc</li>
|
| +
|
| + <li class="file">content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc</li>
|
| +
|
| + <li class="file">content/browser/service_worker/service_worker_dispatcher_host.cc</li>
|
| +
|
| + <li class="file">content/browser/service_worker/service_worker_dispatcher_host.h</li>
|
| +
|
| + <li class="file">content/browser/service_worker/service_worker_dispatcher_host_unittest.cc</li>
|
| +
|
| + <li class="file">content/browser/service_worker/service_worker_handle_unittest.cc</li>
|
| +
|
| + <li class="file">content/browser/service_worker/service_worker_job_unittest.cc</li>
|
| +
|
| + <li class="file">content/browser/service_worker/service_worker_provider_host.cc</li>
|
| +
|
| + <li class="file">content/browser/service_worker/service_worker_provider_host.h</li>
|
| +
|
| + <li class="file">content/browser/service_worker/service_worker_provider_host_unittest.cc</li>
|
| +
|
| + <li class="file">content/browser/service_worker/service_worker_request_handler_unittest.cc</li>
|
| +
|
| + <li class="file">content/browser/service_worker/service_worker_storage_unittest.cc</li>
|
| +
|
| + <li class="file">content/browser/service_worker/service_worker_url_request_job_unittest.cc</li>
|
| +
|
| + <li class="file">content/browser/service_worker/service_worker_version_unittest.cc</li>
|
| +
|
| + <li class="file">content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc</li>
|
| +
|
| + <li class="file">content/child/service_worker/service_worker_network_provider.cc</li>
|
| +
|
| + <li class="file">content/child/service_worker/service_worker_network_provider.h</li>
|
| +
|
| + <li class="file">content/common/service_worker/service_worker_messages.h</li>
|
| +
|
| + <li class="file">content/public/browser/content_browser_client.h</li>
|
| +
|
| + <li class="file">content/renderer/render_frame_impl.cc</li>
|
| +
|
| + <li class="file">content/renderer/service_worker/service_worker_context_client.cc</li>
|
| +
|
| + <li class="file">content/renderer/shared_worker/embedded_shared_worker_stub.cc</li>
|
| +
|
| + <li class="file">third_party/WebKit/LayoutTests/http/tests/serviceworker/insecure-parent-frame.html</li>
|
| +
|
| + <li class="file">third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/insecure-inscope.html</li>
|
| +
|
| + <li class="file">third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/insecure-parent.html</li>
|
| +
|
| + <li class="file">third_party/WebKit/Source/core/dom/Document.cpp</li>
|
| +
|
| + <li class="file">third_party/WebKit/Source/core/dom/Document.h</li>
|
| +
|
| + <li class="file">third_party/WebKit/Source/core/frame/Frame.cpp</li>
|
| +
|
| + <li class="file">third_party/WebKit/Source/core/frame/Frame.h</li>
|
| +
|
| + <li class="file">third_party/WebKit/Source/web/WebFrame.cpp</li>
|
| +
|
| + <li class="file">third_party/WebKit/Source/web/tests/WebFrameTest.cpp</li>
|
| +
|
| + <li class="file">third_party/WebKit/public/web/WebFrame.h</li>
|
| +
|
| + </ul>
|
| +
|
| +
|
| </li>
|
|
|
| <li>
|
| <h3>Update GN docs about target_cpu to encourage use of current_cpu</h3>
|
| + <table class="info">
|
| + <tbody>
|
| + <tr>
|
| + <td class="left">Changed by</td>
|
| + <td class="value">
|
| +
|
| + agrieve<span style="display:none">ohnoyoudont</span>@chromium.org
|
| + </td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Changed at</td>
|
| + <td class="value"><span class="local-time" data-timestamp="1465417955000">Wednesday, 08-Jun-16 13:32:35 PDT</span></td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Repository</td>
|
| + <td class="value">https://chromium.googlesource.com/chromium/src</td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Branch</td>
|
| + <td class="value"></td>
|
| + </tr>
|
| + <tr>
|
| + <td class="left">Revision</td>
|
| + <td class="value"><a href="https://chromium.googlesource.com/chromium/src/+/bfdee36d31a624d330b60b481fc26d10dff81b97">bfdee36d31a624d330b60b481fc26d10dff81b97</a></td>
|
| + </tr>
|
| + </tbody>
|
| + </table>
|
| +
|
| +
|
| + <h3>Comments</h3>
|
| + <pre class="comments">Update GN docs about target_cpu to encourage use of current_cpu
|
| +
|
| +BUG=616819
|
| +
|
| +Review-Url: https://codereview.chromium.org/2038733003
|
| +Cr-Commit-Position: refs/heads/master@{#398661}
|
| +</pre>
|
|
|
| +
|
| +
|
| + <h3 class="files">Changed files</h3>
|
| + <ul class="alternating">
|
| +
|
| + <li class="file">tools/gn/docs/cross_compiles.md</li>
|
| +
|
| + <li class="file">tools/gn/variables.cc</li>
|
| +
|
| + </ul>
|
| +
|
| +
|
| </li>
|
|
|
| </ol>
|
|
|
Chromium Code Reviews
Issue 2823413002:
Milo buildbot: Add in the rest of the blame/commits information. (Closed)
