milo/appengine/frontend/templates/pages/build.html - Issue 2823413002: Milo buildbot: Add in the rest of the blame/commits information.

Side by Side Diff: milo/appengine/frontend/templates/pages/build.html

Issue 2823413002: Milo buildbot: Add in the rest of the blame/commits information. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« milo/appengine/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.json ('K') | « milo/appengine/frontend/static/buildbot/css/default.css ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {{define "title"}}	1 {{define "title"}}

2 {{ with .Build.Summary -}}	2 {{ with .Build.Summary -}}

3 {{ if eq .Status.String "InfraFailure" }}	3 {{ if eq .Status.String "InfraFailure" }}

4 Exception	4 Exception

5 {{ else if eq .Status.String "Failure" }}	5 {{ else if eq .Status.String "Failure" }}

6 Failed	6 Failed

7 {{ else if eq .Status.String "NotRun" }}	7 {{ else if eq .Status.String "NotRun" }}

8 Pending	8 Pending

9 {{ else }}	9 {{ else }}

10 {{ .Status.String }}	10 {{ .Status.String }}

(...skipping 76 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
87	87

88 {{ if .Commit.Repo }}	88 {{ if .Commit.Repo }}

89 <tr><td class="left">Repository</td><td>{{ .Commit.Repo }}</td></tr>	89 <tr><td class="left">Repository</td><td>{{ .Commit.Repo }}</td></tr>

90 {{ end }}	90 {{ end }}

91	91

92 {{ if .Commit.Branch }}	92 {{ if .Commit.Branch }}

93 <tr><td class="left">Branch</td><td>{{ .Commit.Branch }}</td></tr>	93 <tr><td class="left">Branch</td><td>{{ .Commit.Branch }}</td></tr>

94 {{ end }}	94 {{ end }}

95	95

96 {{ if .Commit.RequestRevision }}	96 {{ if .Commit.RequestRevision }}

97 <tr><td class="left">Revision</td><td>{{ .Commit.RequestRevision }}</td> </tr>	97 <tr><td class="left">Revision</td><td>{{ .Commit.RequestRevision \| linki fy }}</td></tr>

98 {{ end }}	98 {{ end }}

99	99

100 {{ if .Commit.Revision }}	100 {{ if .Commit.Revision }}

101 <tr><td class="left">Got Revision</td><td>{{ .Commit.Revision }}</td></t r>	101 <tr><td class="left">Got Revision</td><td>{{ .Commit.Revision \| linkify }}</td></tr>

102 {{ end }}	102 {{ end }}

103	103

104 {{ if .Commit.Changelist }}	104 {{ if .Commit.Changelist }}

105 <tr><td class="left">Patch</td><td>{{ .Commit.Changelist \| linkify }}</t d></tr>	105 <tr><td class="left">Patch</td><td>{{ .Commit.Changelist \| linkify }}</t d></tr>

106 {{ end }}	106 {{ end }}

107	107

108 </table>	108 </table>

109 {{ end }} <!-- with -->	109 {{ end }} <!-- with -->

110 {{ end }} <!-- if -->	110 {{ end }} <!-- if -->

111	111

(...skipping 142 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
254	254

255 </div>	255 </div>

256	256

257 {{ if .Build.Blame}}	257 {{ if .Build.Blame}}

258 <div class="column">	258 <div class="column">

259 <h2>All Changes:</h2>	259 <h2>All Changes:</h2>

260 <ol>	260 <ol>

261 {{ range .Build.Blame }}	261 {{ range .Build.Blame }}

262 <li>	262 <li>

263 <h3>{{.Title}}</h3>	263 <h3>{{.Title}}</h3>

264 <!--- TODO(hinoka): Layout the rest of this -->	264 <table class="info">

	265 <tbody>

	266 <tr>

	267 <td class="left">Changed by</td>

	268 <td><b>
	nodir 2017/04/19 18:37:48 shouldn't we use CSS instead of <b> here and in fi shouldn't we use CSS instead of <b> here and in files? hinoka 2017/04/20 22:09:44 We could do that, <b> was because buildbot did it Show quoted text On 2017/04/19 18:37:48, nodir wrote: > shouldn't we use CSS instead of <b> here and in files? We could do that, <b> was because buildbot did it and I copied it over.
	269 {{ if .AuthorName }}{{ .AuthorName }} - {{ end }}

	270 {{ .AuthorEmail \| obfuscateEmail }}

	271 </b></td>

	272 </tr>

	273 <tr>

	274 <td class="left">Changed at</td>

	275 <td><b>{{ .CommitTime \| localTime "N/A" }}</b></td>

	276 </tr>

	277 <tr>

	278 <td class="left">Repository</td>

	279 <td><b>{{ .Repo }}</b></td>

	280 </tr>

	281 <tr>

	282 <td class="left">Branch</td>

	283 <td><b>{{ .Branch }}</b></td>

	284 </tr>

	285 <tr>

	286 <td class="left">Revision</td>

	287 <td><b>{{ .Revision \| linkify }}</b></td>

	288 </tr>

	289 </tbody>

	290 </table>

	291

	292 {{ if .Description }}

	293 <h3>Comments</h3>

	294 <pre class="comments">{{ .Description }}</pre>

	295 {{ end }}

	296

	297 {{ if .File }}

	298 <h3 class="files">Changed files</h3>

	299 <ul class="alternating">

	300 {{ range .File }}

	301 <li><b>{{ . }}</b></li>

	302 {{ end }}

	303 </ul>

	304 {{ end }}

	305

265 </li>	306 </li>

266 {{ end }}	307 {{ end }}

267 </ol>	308 </ol>

268 </div>	309 </div>

269 {{ end }}	310 {{ end }}

270 </div>	311 </div>

271 </div>	312 </div>

272 <script language="javascript">	313 <script language="javascript">

273 $(document).ready(function() {	314 $(document).ready(function() {

274 var check = function(checked) {	315 var check = function(checked) {

(...skipping 11 matching lines...) Expand all Loading...
286 }	327 }

287 };	328 };

288	329

289 check($("#showHidden").is(":checked"));	330 check($("#showHidden").is(":checked"));

290 $("#showHidden").click(function(e) {	331 $("#showHidden").click(function(e) {

291 check($(this).is(":checked"));	332 check($(this).is(":checked"));

292 });	333 });

293 });	334 });

294 </script>	335 </script>

295 {{end}}	336 {{end}}

OLD	NEW