Milo buildbot: Add in the rest of the blame/commits information.

milo/appengine/backend/git/gitiles.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package git
 
 import (
         "encoding/json"
         "fmt"
         "net/http"
@@ skipping 47 matching lines @@
 // fixURL validates and normalizes a repoURL and treeish, and returns the
 // log JSON gitiles URL.
 func fixURL(repoURL, treeish string) (string, error) {
         u, err := url.Parse(repoURL)
         if err != nil {
                 return "", err
         }
         if u.Scheme != "https" {
                 return "", fmt.Errorf("%s should start with https://", repoURL)
         }
         if !strings.HasSuffix(u.Host, "googlesource.com") {

[nodir, 2017/04/19 18:37:48]

it must be ".googlesource.com"
otherwise one may use hackedgooglesource.com

[hinoka, 2017/04/20 22:09:43]

Done.

                 return "", fmt.Errorf("Only googlesource.com repos supported")
         }
         // Use the authenticated URL
         u.Path = "a/" + u.Path
         URL := fmt.Sprintf("%s/+log/%s?format=JSON", u.String(), treeish)
         return URL, nil
 }
 
 // GetCommits returns a list of commits based on a repo and treeish (usually
 // a branch).  This should be equivilent of a "git log <treeish>" call in
@@ skipping 27 matching lines @@
         // TODO(hinoka): If there is a page and we have gotten less than the limit,
         // keep making requests for the next page until we have enough commits.
 
         // Move things into our own datastructure.
         result := make([]resp.Commit, len(commits.Log))
         for i, log := range commits.Log {
                 result[i] = resp.Commit{
                         AuthorName:  log.Author.Name,
                         AuthorEmail: log.Author.Email,
                         Repo:        repoURL,
-                        Revision:    log.Commit,
+                        Revision: &resp.Link{
+                                Label: log.Commit,
+                                URL:   repoURL + "/+/" + log.Commit,
+                        },
                         Description: log.Message,
                         Title:       strings.SplitN(log.Message, "\n", 2)[0],
                         // TODO(hinoka): Fill in the rest of resp.Commit and add those details
                         // in the html.
                 }
         }
         return result, nil
 }