Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: milo/appengine/buildbucket/common.go

Issue 2823413002: Milo buildbot: Add in the rest of the blame/commits information. (Closed)
Patch Set: Review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/buildbucket/common.go
diff --git a/milo/appengine/buildbucket/common.go b/milo/appengine/buildbucket/common.go
index c10d192df5c45e74620f8582246f910921dad6a4..8e3d879e1253ac865c5e2db5088586c875b07e2a 100644
--- a/milo/appengine/buildbucket/common.go
+++ b/milo/appengine/buildbucket/common.go
@@ -113,13 +113,17 @@ func getChangeList(
case "rietveld":
if prop.RietveldURL != "" && prop.Issue != 0 {
result = &resp.Commit{
- Revision: resultDetails.Properties.GotRevision,
- RequestRevision: prop.Revision,
+ RequestRevision: &resp.Link{Label: prop.Revision},
Changelist: &resp.Link{
Label: fmt.Sprintf("Rietveld CL %d", prop.Issue),
URL: fmt.Sprintf("%s/%d/#ps%d", prop.RietveldURL, prop.Issue, prop.PatchSet),
},
}
+ if resultDetails.Properties.GotRevision != "" {
+ // TODO(hinoka): Figure out the full URL for these revisions, add it
+ // to the URL field.
+ result.Revision = &resp.Link{Label: resultDetails.Properties.GotRevision}
+ }
}
case "gerrit":
« no previous file with comments | « milo/appengine/buildbot/structs.go ('k') | milo/appengine/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698