Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: milo/appengine/console/console.go

Issue 2823413002: Milo buildbot: Add in the rest of the blame/commits information. (Closed)
Patch Set: Review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/console/console.go
diff --git a/milo/appengine/console/console.go b/milo/appengine/console/console.go
index 841c420a78ddfa83216a406393f1e9295dbbfe7d..8d3da7f91988e845b232ccb693225365c9c64233 100644
--- a/milo/appengine/console/console.go
+++ b/milo/appengine/console/console.go
@@ -70,8 +70,10 @@ func console(c context.Context, project, name string) (*resp.Console, error) {
tGitiles := clock.Now(c)
logging.Debugf(c, "Loading commits took %s.", tGitiles.Sub(tStart))
commitNames := make([]string, len(commits))
+ commitLinks := make([]*resp.Link, len(commits))
for i, commit := range commits {
- commitNames[i] = commit.Revision
+ commitNames[i] = commit.Revision.Label
+ commitLinks[i] = commit.Revision
}
// HACK(hinoka): This only supports buildbot....
@@ -88,7 +90,7 @@ func console(c context.Context, project, name string) (*resp.Console, error) {
return nil, err
}
ccb := make([]resp.CommitBuild, len(commits))
- for i, commit := range commitNames {
+ for i, commit := range commitLinks {
// TODO(hinoka): Not like this
ccb[i].Commit = resp.Commit{Revision: commit}
ccb[i].Build = cb[i]

Powered by Google App Engine
This is Rietveld 408576698