Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2819773002: Change <menuitem> parsing rules to match spec (Closed)

Created:
3 years, 8 months ago by yuzuchan
Modified:
3 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, loading-reviews+parser_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change <menuitem> parsing rules to match spec This CL changes <menuitem> parsing rules so that they match the current spec. <menuitem> is no more a self closing tag. The link below shows the latest change made to the spec. https://github.com/whatwg/html/pull/2319 BUG=412945 Review-Url: https://codereview.chromium.org/2819773002 Cr-Commit-Position: refs/heads/master@{#464906} Committed: https://chromium.googlesource.com/chromium/src/+/90d6ed690cab69c72e9a8994ed209f7b3432e44c

Patch Set 1 #

Patch Set 2 : Fixed a gTest using menuitem #

Patch Set 3 : Fix affected tests #

Patch Set 4 : Fix affected layout test #

Messages

Total messages: 26 (22 generated)
yuzuchan
PTAL:) This is how I feel about this patch: http://i.imgur.com/bqg5jea.gif
3 years, 8 months ago (2017-04-17 07:59:56 UTC) #19
tkent
On 2017/04/17 at 07:59:56, yuzus wrote: > This is how I feel about this patch: ...
3 years, 8 months ago (2017-04-17 08:40:47 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819773002/60001
3 years, 8 months ago (2017-04-17 08:46:48 UTC) #23
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 08:50:51 UTC) #26
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/90d6ed690cab69c72e9a8994ed20...

Powered by Google App Engine
This is Rietveld 408576698