third_party/WebKit/LayoutTests/fast/parser/parse-menuitem.html - Issue 2819773002: Change <menuitem> parsing rules to match spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/parser/parse-menuitem.html

Issue 2819773002: Change <menuitem> parsing rules to match spec (Closed)

Patch Set: Fix affected layout test Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/html/syntax/serializing-html-fragments/serializing-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/parser/parse-menuitem-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/parser/parse-menuitem.html

diff --git a/third_party/WebKit/LayoutTests/fast/parser/parse-menuitem.html b/third_party/WebKit/LayoutTests/fast/parser/parse-menuitem.html

index e3e57b2ecf48c01b36c4dd38d538b7b38019844b..58348ce4e98108655fa0239e1ae548c81c03c728 100644

--- a/third_party/WebKit/LayoutTests/fast/parser/parse-menuitem.html

+++ b/third_party/WebKit/LayoutTests/fast/parser/parse-menuitem.html

@@ -2,12 +2,12 @@

<head>

</head>

-<div id="div"><menuitem></div>

-<menu id="menu" type=context><menuitem id="first_item"><menuitem id="second_item"></menu>

+<div id="div"><menuitem></menuitem></div>

+<menu id="menu" type=context><menuitem id="first_item"></menuitem><menuitem id="second_item"></menuitem></menu>

-description("This test checks parsing of menuitem tag which is a self closing tag with no end tag.");

-shouldBeEqualToString("document.getElementById('div').innerHTML", "<menuitem>");

-shouldBeEqualToString("document.getElementById('menu').innerHTML", "<menuitem id=\"first_item\"><menuitem id=\"second_item\">");

+description("This test checks parsing of menuitem tag which has an end tag.");

+shouldBeEqualToString("document.getElementById('div').innerHTML", "<menuitem></menuitem>");

+shouldBeEqualToString("document.getElementById('menu').innerHTML", "<menuitem id=\"first_item\"></menuitem><menuitem id=\"second_item\"></menuitem>");

shouldBeNull("document.getElementById('first_item').firstChild");

shouldBe("document.getElementById('menu').firstChild.nextSibling", "document.getElementById('second_item')");

</script>