Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Unified Diff: third_party/WebKit/Source/core/page/ContextMenuControllerTest.cpp

Issue 2819773002: Change <menuitem> parsing rules to match spec (Closed)
Patch Set: Fix affected layout test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/page/ContextMenuControllerTest.cpp
diff --git a/third_party/WebKit/Source/core/page/ContextMenuControllerTest.cpp b/third_party/WebKit/Source/core/page/ContextMenuControllerTest.cpp
index 97184b3adf9519f0cd054f18b7acf118b4ec966f..0e97601f975388395ca3d12f7cde55e196603adf 100644
--- a/third_party/WebKit/Source/core/page/ContextMenuControllerTest.cpp
+++ b/third_party/WebKit/Source/core/page/ContextMenuControllerTest.cpp
@@ -41,18 +41,25 @@ TEST_F(ContextMenuControllerTest, TestCustomMenu) {
"width: 100px;\">"
"<menu type=\"context\" id=\"menu_id\">"
"<menuitem label=\"Item1\" onclick='document.title = \"Title 1\";'>"
+ "</menuitem>"
"<menuitem label=\"Item2\" onclick='document.title = \"Title 2\";'>"
+ "</menuitem>"
"<menuitem label=\"Item3\" onclick='document.title = \"Title 3\";'>"
+ "</menuitem>"
"<menu label='Submenu'>"
"<menuitem label=\"Item4\" onclick='document.title = \"Title 4\";'>"
+ "</menuitem>"
"<menuitem label=\"Item5\" onclick='document.title = \"Title 5\";'>"
+ "</menuitem>"
"<menuitem label=\"Item6\" onclick='document.title = \"Title 6\";'>"
+ "</menuitem>"
"</menu>"
"<menuitem id=\"item7\" type=\"checkbox\" checked label=\"Item7\""
"onclick='if "
"(document.getElementById(\"item7\").hasAttribute(\"checked\"))"
"document.title = \"Title 7 checked\"; else document.title = \"Title 7 "
"not checked\";'>"
+ "</menuitem>"
"<menuitem id=\"item8\" type=\"radio\" radiogroup=\"group\" "
"label=\"Item8\""
"onclick='if "
@@ -60,12 +67,14 @@ TEST_F(ContextMenuControllerTest, TestCustomMenu) {
"document.title = \"Title 8 checked\"; else if "
"(document.getElementById(\"item9\").hasAttribute(\"checked\"))"
"document.title = \"Title 8 not checked and Title 9 checked\";'>"
+ "</menuitem>"
"<menuitem id=\"item9\" type=\"radio\" radiogroup=\"group\" checked "
"label=\"Item9\""
"onclick='if "
"(document.getElementById(\"item9\").hasAttribute(\"checked\"))"
"document.title = \"Title 9 checked\"; else document.title = \"Title 9 "
"not checked\";'>"
+ "</menuitem>"
"<menuitem id=\"item10\" type=\"radio\" radiogroup=\"group\" "
"label=\"Item10\""
"onclick='if "
@@ -73,6 +82,7 @@ TEST_F(ContextMenuControllerTest, TestCustomMenu) {
"document.title = \"Title 10 checked\"; else if "
"(document.getElementById(\"item8\").hasAttribute(\"checked\"))"
"document.title = \"Title 10 not checked and Title 8 checked\";'>"
+ "</menuitem>"
"</menu>"
"</button>");
« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698