third_party/WebKit/LayoutTests/html/menu_menuitem/menuitem-click.html - Issue 2819773002: Change <menuitem> parsing rules to match spec

Side by Side Diff: third_party/WebKit/LayoutTests/html/menu_menuitem/menuitem-click.html

Issue 2819773002: Change <menuitem> parsing rules to match spec (Closed)

Patch Set: Fix affected layout test Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/parser/parse-menuitem-expected.txt ('k') | third_party/WebKit/Source/core/html/HTMLElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <script src="../../resources/js-test.js"></script>	1 <script src="../../resources/js-test.js"></script>

2 <menu type=context>	2 <menu type=context>

3 <menuitem id=mi1 type=checkbox>	3 <menuitem id=mi1 type=checkbox></menuitem>

4 <menuitem id=mi2 type=radio radiogroup="g1" checked>	4 <menuitem id=mi2 type=radio radiogroup="g1" checked></menuitem>

5 <menuitem id=mi3 type=radio radiogroup="g1">	5 <menuitem id=mi3 type=radio radiogroup="g1"></menuitem>

6 <menuitem id=mi4 type=radio radiogroup="g1">	6 <menuitem id=mi4 type=radio radiogroup="g1"></menuitem>

7 <menu label="Submenu">	7 <menu label="Submenu">

8 <menuitem id=_mi1 type=radio radiogroup="g1">	8 <menuitem id=_mi1 type=radio radiogroup="g1"></menuitem>

9 <menuitem id=_mi2 type=radio radiogroup="g1">	9 <menuitem id=_mi2 type=radio radiogroup="g1"></menuitem>

10 <menuitem id=_mi3 type=radio radiogroup="g1">	10 <menuitem id=_mi3 type=radio radiogroup="g1"></menuitem>

11 </menu>	11 </menu>

12 <menuitem id=mi5 type=radio radiogroup="g2" checked>	12 <menuitem id=mi5 type=radio radiogroup="g2" checked></menuitem>

13 <menuitem id=mi6 type=radio radiogroup="G2">	13 <menuitem id=mi6 type=radio radiogroup="G2"></menuitem>

14 <menuitem id=mi7 type=radio radiogroup=" g3 " checked>	14 <menuitem id=mi7 type=radio radiogroup=" g3 " checked></menuitem>

15 <menuitem id=mi8 type=radio radiogroup=" g3">	15 <menuitem id=mi8 type=radio radiogroup=" g3"></menuitem>

16 <menuitem id=mi9 type=radio radiogroup="" checked>	16 <menuitem id=mi9 type=radio radiogroup="" checked></menuitem>

17 <menuitem id=mi10 type=radio>	17 <menuitem id=mi10 type=radio></menuitem>

18 <menuitem id=mi11 type=radio radiogroup="g4">	18 <menuitem id=mi11 type=radio radiogroup="g4"></menuitem>

19 <menuitem id=mi12 type=checkbox radiogroup="g4" checked>	19 <menuitem id=mi12 type=checkbox radiogroup="g4" checked></menuitem>

20 </menu>	20 </menu>

21 <script>	21 <script>

22	22

23 description('Test that the "checked" attribute of menuitem is toggled with click .');	23 description('Test that the "checked" attribute of menuitem is toggled with click .');

24	24

25 var element = document.getElementById('mi1');	25 var element = document.getElementById('mi1');

26 element.click();	26 element.click();

27 shouldBeTrue('element.hasAttribute("checked")');	27 shouldBeTrue('element.hasAttribute("checked")');

28 element.click();	28 element.click();

29 shouldBeFalse('element.hasAttribute("checked")');	29 shouldBeFalse('element.hasAttribute("checked")');

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
63 mi10.click();	63 mi10.click();

64 shouldBeFalse('mi9.hasAttribute("checked")');	64 shouldBeFalse('mi9.hasAttribute("checked")');

65 shouldBeTrue('mi10.hasAttribute("checked")');	65 shouldBeTrue('mi10.hasAttribute("checked")');

66 // Test that radiogroup attribute is ignored if type is not radio.	66 // Test that radiogroup attribute is ignored if type is not radio.

67 var mi11 = document.getElementById('mi11');	67 var mi11 = document.getElementById('mi11');

68 var mi12 = document.getElementById('mi12');	68 var mi12 = document.getElementById('mi12');

69 mi11.click();	69 mi11.click();

70 shouldBeTrue('mi11.hasAttribute("checked")');	70 shouldBeTrue('mi11.hasAttribute("checked")');

71 shouldBeFalse('mi12.hasAttribute("checked")');	71 shouldBeFalse('mi12.hasAttribute("checked")');

72 </script>	72 </script>

OLD	NEW