third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp - Issue 2819773002: Change <menuitem> parsing rules to match spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp

Issue 2819773002: Change <menuitem> parsing rules to match spec (Closed)

Patch Set: Fix affected layout test Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp b/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp

index 79c3a82d066eb0a2a78cc01576407ac533408312..056c0657bc9159a45ea46ecb89899740a5e8498d 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp

@@ -732,9 +732,7 @@ void HTMLTreeBuilder::ProcessStartTagForInBody(AtomicHTMLToken* token) {

frameset_ok_ = false;

return;

}

- if ((RuntimeEnabledFeatures::contextMenuEnabled() &&

- token->GetName() == menuitemTag) ||

- token->GetName() == paramTag || token->GetName() == sourceTag ||

+ if (token->GetName() == paramTag || token->GetName() == sourceTag ||

token->GetName() == trackTag) {

tree_.InsertSelfClosingHTMLElementDestroyingToken(token);

return;