Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLElement.cpp

Issue 2819773002: Change <menuitem> parsing rules to match spec (Closed)
Patch Set: Fix affected layout test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2004-2008, 2013, 2014 Apple Inc. All rights reserved. 4 * Copyright (C) 2004-2008, 2013, 2014 Apple Inc. All rights reserved.
5 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 5 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
6 * (http://www.torchmobile.com/) 6 * (http://www.torchmobile.com/)
7 * Copyright (C) 2011 Motorola Mobility. All rights reserved. 7 * Copyright (C) 2011 Motorola Mobility. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 } 137 }
138 return Element::nodeName(); 138 return Element::nodeName();
139 } 139 }
140 140
141 bool HTMLElement::ShouldSerializeEndTag() const { 141 bool HTMLElement::ShouldSerializeEndTag() const {
142 // See https://www.w3.org/TR/DOM-Parsing/ 142 // See https://www.w3.org/TR/DOM-Parsing/
143 if (HasTagName(areaTag) || HasTagName(baseTag) || HasTagName(basefontTag) || 143 if (HasTagName(areaTag) || HasTagName(baseTag) || HasTagName(basefontTag) ||
144 HasTagName(bgsoundTag) || HasTagName(brTag) || HasTagName(colTag) || 144 HasTagName(bgsoundTag) || HasTagName(brTag) || HasTagName(colTag) ||
145 HasTagName(embedTag) || HasTagName(frameTag) || HasTagName(hrTag) || 145 HasTagName(embedTag) || HasTagName(frameTag) || HasTagName(hrTag) ||
146 HasTagName(imgTag) || HasTagName(inputTag) || HasTagName(keygenTag) || 146 HasTagName(imgTag) || HasTagName(inputTag) || HasTagName(keygenTag) ||
147 HasTagName(linkTag) || HasTagName(menuitemTag) || HasTagName(metaTag) || 147 HasTagName(linkTag) || HasTagName(metaTag) || HasTagName(paramTag) ||
148 HasTagName(paramTag) || HasTagName(sourceTag) || HasTagName(trackTag) || 148 HasTagName(sourceTag) || HasTagName(trackTag) || HasTagName(wbrTag))
149 HasTagName(wbrTag))
150 return false; 149 return false;
151 return true; 150 return true;
152 } 151 }
153 152
154 static inline CSSValueID UnicodeBidiAttributeForDirAuto(HTMLElement* element) { 153 static inline CSSValueID UnicodeBidiAttributeForDirAuto(HTMLElement* element) {
155 if (element->HasTagName(preTag) || element->HasTagName(textareaTag)) 154 if (element->HasTagName(preTag) || element->HasTagName(textareaTag))
156 return CSSValueWebkitPlaintext; 155 return CSSValueWebkitPlaintext;
157 // FIXME: For bdo element, dir="auto" should result in "bidi-override isolate" 156 // FIXME: For bdo element, dir="auto" should result in "bidi-override isolate"
158 // but we don't support having multiple values in unicode-bidi yet. 157 // but we don't support having multiple values in unicode-bidi yet.
159 // See https://bugs.webkit.org/show_bug.cgi?id=73164. 158 // See https://bugs.webkit.org/show_bug.cgi?id=73164.
(...skipping 1038 matching lines...) Expand 10 before | Expand all | Expand 10 after
1198 1197
1199 #ifndef NDEBUG 1198 #ifndef NDEBUG
1200 1199
1201 // For use in the debugger 1200 // For use in the debugger
1202 void dumpInnerHTML(blink::HTMLElement*); 1201 void dumpInnerHTML(blink::HTMLElement*);
1203 1202
1204 void dumpInnerHTML(blink::HTMLElement* element) { 1203 void dumpInnerHTML(blink::HTMLElement* element) {
1205 printf("%s\n", element->innerHTML().Ascii().Data()); 1204 printf("%s\n", element->innerHTML().Ascii().Data());
1206 } 1205 }
1207 #endif 1206 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698