Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 2811253004: Remove ListValue::Append(raw ptr) on Android (Closed)

Created:
3 years, 8 months ago by vabr (Chromium)
Modified:
3 years, 8 months ago
Reviewers:
jdoerrie, brettw
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vmpstr+watch_chromium.org, jam, darin-cc_chromium.org, agrieve+watch_chromium.org, danakj+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ListValue::Append(raw ptr) on Android ListValue::Append(raw ptr) is deprecated and the unique_ptr version should be used instead. This CL achieves that on Android specifically. BUG=581865 Review-Url: https://codereview.chromium.org/2811253004 Cr-Commit-Position: refs/heads/master@{#464865} Committed: https://chromium.googlesource.com/chromium/src/+/2f38a9ff1e78023cc3fa341a30448d1b9ca5a891

Patch Set 1 #

Patch Set 2 : Add includes #

Total comments: 20

Patch Set 3 : Comments #

Messages

Total messages: 23 (16 generated)
vabr (Chromium)
Hi Jan and Brett! Jan, could you please review the whole patch? Brett, could you ...
3 years, 8 months ago (2017-04-12 15:34:57 UTC) #6
jdoerrie
Thanks Vaclav! Mostly just nits. https://codereview.chromium.org/2811253004/diff/20001/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc File chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc (right): https://codereview.chromium.org/2811253004/diff/20001/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc#newcode15 chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc:15: #include "base/strings/string_number_conversions.h" #include "base/values.h" ...
3 years, 8 months ago (2017-04-12 16:08:55 UTC) #7
vabr (Chromium)
Thanks, Jan! I addressed your comments, please have a look. Cheers, Vaclav https://codereview.chromium.org/2811253004/diff/20001/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc File chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc ...
3 years, 8 months ago (2017-04-12 16:40:53 UTC) #9
jdoerrie
LGTM, thanks Vaclav! https://codereview.chromium.org/2811253004/diff/20001/content/browser/android/java/gin_java_method_invocation_helper.cc File content/browser/android/java/gin_java_method_invocation_helper.cc (right): https://codereview.chromium.org/2811253004/diff/20001/content/browser/android/java/gin_java_method_invocation_helper.cc#newcode261 content/browser/android/java/gin_java_method_invocation_helper.cc:261: result_wrapper.Append(GinJavaBridgeValue::CreateNonFiniteValue(result)); On 2017/04/12 16:40:53, vabr (Chromium) ...
3 years, 8 months ago (2017-04-12 18:30:20 UTC) #11
brettw
lgtm
3 years, 8 months ago (2017-04-14 17:29:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811253004/30001
3 years, 8 months ago (2017-04-15 09:52:42 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-04-15 09:57:08 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/2f38a9ff1e78023cc3fa341a3044...

Powered by Google App Engine
This is Rietveld 408576698