Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: content/browser/android/java/gin_java_method_invocation_helper.cc

Issue 2811253004: Remove ListValue::Append(raw ptr) on Android (Closed)
Patch Set: Comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/java/gin_java_method_invocation_helper.cc
diff --git a/content/browser/android/java/gin_java_method_invocation_helper.cc b/content/browser/android/java/gin_java_method_invocation_helper.cc
index 1a5d1df6a06cf321e757f6f13ade1f8750699bf7..6c5edab76ce42d3a2d52f8b36dc4f8b92a3ad4ef 100644
--- a/content/browser/android/java/gin_java_method_invocation_helper.cc
+++ b/content/browser/android/java/gin_java_method_invocation_helper.cc
@@ -258,8 +258,7 @@ void GinJavaMethodInvocationHelper::InvokeMethod(jobject object,
if (std::isfinite(result)) {
result_wrapper.AppendDouble(result);
} else {
- result_wrapper.Append(
- GinJavaBridgeValue::CreateNonFiniteValue(result).release());
+ result_wrapper.Append(GinJavaBridgeValue::CreateNonFiniteValue(result));
}
break;
}
@@ -270,8 +269,7 @@ void GinJavaMethodInvocationHelper::InvokeMethod(jobject object,
if (std::isfinite(result)) {
result_wrapper.AppendDouble(result);
} else {
- result_wrapper.Append(
- GinJavaBridgeValue::CreateNonFiniteValue(result).release());
+ result_wrapper.Append(GinJavaBridgeValue::CreateNonFiniteValue(result));
}
break;
}
@@ -280,15 +278,13 @@ void GinJavaMethodInvocationHelper::InvokeMethod(jobject object,
env->CallVoidMethodA(object, id, parameters);
else
env->CallStaticVoidMethodA(clazz, id, parameters);
- result_wrapper.Append(
- GinJavaBridgeValue::CreateUndefinedValue().release());
+ result_wrapper.Append(GinJavaBridgeValue::CreateUndefinedValue());
break;
case JavaType::TypeArray:
// LIVECONNECT_COMPLIANCE: Existing behavior is to not call methods that
// return arrays. Spec requires calling the method and converting the
// result to a JavaScript array.
- result_wrapper.Append(
- GinJavaBridgeValue::CreateUndefinedValue().release());
+ result_wrapper.Append(GinJavaBridgeValue::CreateUndefinedValue());
break;
case JavaType::TypeString: {
jstring java_string = static_cast<jstring>(
@@ -305,8 +301,7 @@ void GinJavaMethodInvocationHelper::InvokeMethod(jobject object,
if (!scoped_java_string.obj()) {
// LIVECONNECT_COMPLIANCE: Existing behavior is to return undefined.
// Spec requires returning a null string.
- result_wrapper.Append(
- GinJavaBridgeValue::CreateUndefinedValue().release());
+ result_wrapper.Append(GinJavaBridgeValue::CreateUndefinedValue());
break;
}
result_wrapper.AppendString(

Powered by Google App Engine
This is Rietveld 408576698