Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1469)

Unified Diff: content/renderer/java/gin_java_bridge_value_converter.cc

Issue 2811253004: Remove ListValue::Append(raw ptr) on Android (Closed)
Patch Set: Comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/java/gin_java_bridge_value_converter.cc
diff --git a/content/renderer/java/gin_java_bridge_value_converter.cc b/content/renderer/java/gin_java_bridge_value_converter.cc
index f080f709fe8a71ce800d235904f431996d8c973f..c22cbf3c696056a20e21b407974328dc423e97b2 100644
--- a/content/renderer/java/gin_java_bridge_value_converter.cc
+++ b/content/renderer/java/gin_java_bridge_value_converter.cc
@@ -85,8 +85,7 @@ class TypedArraySerializerImpl : public TypedArraySerializer {
*end = element + typed_array_->Length();
element != end;
++element) {
- const ListType list_value = *element;
- out->Append(new base::Value(list_value));
+ out->Append(base::MakeUnique<base::Value>(ListType(*element)));
}
}

Powered by Google App Engine
This is Rietveld 408576698