Remove ListValue::Append(raw ptr) on Android

content/renderer/java/gin_java_bridge_value_converter.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/java/gin_java_bridge_value_converter.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <cmath>
@@ skipping 68 matching lines @@
 
   void serializeTo(char* data,
                    size_t data_length,
                    base::ListValue* out) override {
     DCHECK_EQ(data_length, typed_array_->Length() * sizeof(ElementType));
     for (ElementType *element = reinterpret_cast<ElementType*>(data),
                      *end = element + typed_array_->Length();
          element != end;
          ++element) {
       const ListType list_value = *element;
-      out->Append(new base::Value(list_value));
+      out->Append(base::MakeUnique<base::Value>(list_value));

[jdoerrie, 2017/04/12 16:08:55]

Inline list_value?

[vabr (Chromium), 2017/04/12 16:40:53]

Done. I admit I was not sure whether the explicit type conversion is important
(without it we could drop the ListType declaration from the template
completely), so I kept it in the inline version.

[jdoerrie, 2017/04/12 18:30:19]

True, good point. I think having ListType explicit is the correct choice. It
could be possible that at some point there will be a base::Value(char)
constructor, setting the type to STRING. This would result in a surprising
change for this code if we dropped the template parameter.

     }
   }
 
  private:
   explicit TypedArraySerializerImpl(v8::Local<v8::TypedArray> typed_array)
       : typed_array_(typed_array) {}
 
   v8::Local<v8::TypedArray> typed_array_;
 
   DISALLOW_COPY_AND_ASSIGN(TypedArraySerializerImpl);
@@ skipping 60 matching lines @@
   return true;
 }
 
 bool GinJavaBridgeValueConverter::FromV8Undefined(
     std::unique_ptr<base::Value>* out) const {
   *out = GinJavaBridgeValue::CreateUndefinedValue();
   return true;
 }
 
 }  // namespace content