Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: chrome/browser/android/bookmarks/partner_bookmarks_shim.cc

Issue 2811253004: Remove ListValue::Append(raw ptr) on Android (Closed)
Patch Set: Comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/values.cc ('k') | chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/bookmarks/partner_bookmarks_shim.cc
diff --git a/chrome/browser/android/bookmarks/partner_bookmarks_shim.cc b/chrome/browser/android/bookmarks/partner_bookmarks_shim.cc
index bd15315a24d0f70f16b61749fd1173554ef3132f..b1cc32211705af4a3c80315f1a52de1b66a298c2 100644
--- a/chrome/browser/android/bookmarks/partner_bookmarks_shim.cc
+++ b/chrome/browser/android/bookmarks/partner_bookmarks_shim.cc
@@ -5,8 +5,10 @@
#include "chrome/browser/android/bookmarks/partner_bookmarks_shim.h"
#include <tuple>
+#include <utility>
#include "base/lazy_instance.h"
+#include "base/memory/ptr_util.h"
#include "base/values.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/pref_names.h"
@@ -282,11 +284,11 @@ void PartnerBookmarksShim::SaveNodeMapping() {
for (NodeRenamingMap::const_iterator i = node_rename_remove_map_.begin();
i != node_rename_remove_map_.end();
++i) {
- base::DictionaryValue* dict = new base::DictionaryValue();
+ auto dict = base::MakeUnique<base::DictionaryValue>();
dict->SetString(kMappingUrl, i->first.url().spec());
dict->SetString(kMappingProviderTitle, i->first.provider_title());
dict->SetString(kMappingTitle, i->second);
- list.Append(dict);
+ list.Append(std::move(dict));
}
prefs_->Set(prefs::kPartnerBookmarkMappings, list);
}
« no previous file with comments | « base/values.cc ('k') | chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698