Remove ListValue::Append(raw ptr) on Android

content/renderer/java/gin_java_function_invocation_helper.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/java/gin_java_function_invocation_helper.h"
 
+#include <utility>
+
 #include "base/memory/ptr_util.h"

[jdoerrie, 2017/04/12 16:08:55]

#include "base/values.h"

[vabr (Chromium), 2017/04/12 16:40:53]

Done.

 #include "content/common/android/gin_java_bridge_errors.h"
 #include "content/common/android/gin_java_bridge_value.h"
 #include "content/public/child/v8_value_converter.h"
 #include "content/renderer/java/gin_java_bridge_object.h"
 #include "content/renderer/java/gin_java_bridge_value_converter.h"
 
 namespace content {
 
 namespace {
 
@@ skipping 39 matching lines @@
   }
 
   base::ListValue arguments;
   {
     v8::HandleScope handle_scope(args->isolate());
     v8::Local<v8::Context> context = args->isolate()->GetCurrentContext();
     v8::Local<v8::Value> val;
     while (args->GetNext(&val)) {
       std::unique_ptr<base::Value> arg(converter_->FromV8Value(val, context));
       if (arg.get()) {
-        arguments.Append(arg.release());
+        arguments.Append(std::move(arg));

[jdoerrie, 2017/04/12 16:08:55]

Consider removing braces around if and else.

[vabr (Chromium), 2017/04/12 16:40:53]

Admittedly, this file is itself not consistent in this respect, so I don't see
harm removing the braces. My personal preference is to always keep them just to
save the mental effort to check if they should be there or not, but I don't feel
strongly here. :)

[jdoerrie, 2017/04/12 18:30:19]

Alright, sounds good :) I am not feeling too strongly about it either, I just
have gotten used to not seeing them for one-line statements. Both versions are
fine according to the style guide IIRC, so it's fine either way.

       } else {
         arguments.Append(base::MakeUnique<base::Value>());
       }
     }
   }
 
   GinJavaBridgeError error;
   std::unique_ptr<base::Value> result = dispatcher_->InvokeJavaMethod(
       object->object_id(), method_name_, arguments, &error);
   if (!result.get()) {
@@ skipping 23 matching lines @@
     }
   } else if (gin_value->IsType(GinJavaBridgeValue::TYPE_NONFINITE)) {
     float float_value;
     gin_value->GetAsNonFinite(&float_value);
     return v8::Number::New(args->isolate(), float_value);
   }
   return v8::Undefined(args->isolate());
 }
 
 }  // namespace content