Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2782783002: Remove redundant WebLocalFrame* parameter from didFinishDocumentLoad (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index b17d570639093875c1df7bb5afbd68c0132bea9f..44a2d7f644e5c0ae37e62f8c841d4614cd8444bf 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -10080,9 +10080,7 @@ class CallbackOrderingWebFrameClient
WebHistoryCommitType) override {
EXPECT_EQ(2, m_callbackCount++);
}
- void didFinishDocumentLoad(WebLocalFrame*) override {
- EXPECT_EQ(3, m_callbackCount++);
- }
+ void didFinishDocumentLoad() override { EXPECT_EQ(3, m_callbackCount++); }
void didHandleOnloadEvents(WebLocalFrame*) override {
EXPECT_EQ(4, m_callbackCount++);
}
@@ -11268,7 +11266,7 @@ TEST_F(WebFrameTest, NoLoadingCompletionCallbacksInDetach) {
EXPECT_TRUE(false) << "The load should not have failed.";
}
- void didFinishDocumentLoad(WebLocalFrame*) override {
+ void didFinishDocumentLoad() override {
// TODO(dcheng): Investigate not calling this as well during frame detach.
m_didCallDidFinishDocumentLoad = true;
}
« no previous file with comments | « third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp ('k') | third_party/WebKit/public/web/WebFrameClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698