Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: third_party/WebKit/Source/web/LocalFrameClientImpl.cpp

Issue 2782783002: Remove redundant WebLocalFrame* parameter from didFinishDocumentLoad (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 360 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 m_webFrame->client()->didReceiveResponse(webresp); 371 m_webFrame->client()->didReceiveResponse(webresp);
372 } 372 }
373 } 373 }
374 374
375 void LocalFrameClientImpl::dispatchDidFinishDocumentLoad() { 375 void LocalFrameClientImpl::dispatchDidFinishDocumentLoad() {
376 // TODO(dglazkov): Sadly, workers are WebFrameClients, and they can totally 376 // TODO(dglazkov): Sadly, workers are WebFrameClients, and they can totally
377 // destroy themselves when didFinishDocumentLoad is invoked, and in turn 377 // destroy themselves when didFinishDocumentLoad is invoked, and in turn
378 // destroy the fake WebLocalFrame that they create, which means that you 378 // destroy the fake WebLocalFrame that they create, which means that you
379 // should not put any code touching `this` after the two lines below. 379 // should not put any code touching `this` after the two lines below.
380 if (m_webFrame->client()) 380 if (m_webFrame->client())
381 m_webFrame->client()->didFinishDocumentLoad(m_webFrame); 381 m_webFrame->client()->didFinishDocumentLoad();
382 } 382 }
383 383
384 void LocalFrameClientImpl::dispatchDidLoadResourceFromMemoryCache( 384 void LocalFrameClientImpl::dispatchDidLoadResourceFromMemoryCache(
385 const ResourceRequest& request, 385 const ResourceRequest& request,
386 const ResourceResponse& response) { 386 const ResourceResponse& response) {
387 if (m_webFrame->client()) { 387 if (m_webFrame->client()) {
388 m_webFrame->client()->didLoadResourceFromMemoryCache( 388 m_webFrame->client()->didLoadResourceFromMemoryCache(
389 WrappedResourceRequest(request), WrappedResourceResponse(response)); 389 WrappedResourceRequest(request), WrappedResourceResponse(response));
390 } 390 }
391 } 391 }
(...skipping 641 matching lines...) Expand 10 before | Expand all | Expand 10 after
1033 if (m_webFrame->client()) 1033 if (m_webFrame->client())
1034 m_webFrame->client()->setHasReceivedUserGesture(); 1034 m_webFrame->client()->setHasReceivedUserGesture();
1035 } 1035 }
1036 1036
1037 void LocalFrameClientImpl::abortClientNavigation() { 1037 void LocalFrameClientImpl::abortClientNavigation() {
1038 if (m_webFrame->client()) 1038 if (m_webFrame->client())
1039 m_webFrame->client()->abortClientNavigation(); 1039 m_webFrame->client()->abortClientNavigation();
1040 } 1040 }
1041 1041
1042 } // namespace blink 1042 } // namespace blink
OLDNEW
« no previous file with comments | « content/shell/test_runner/web_frame_test_proxy.h ('k') | third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698