third_party/WebKit/Source/web/LocalFrameClientImpl.cpp - Issue 2782783002: Remove redundant WebLocalFrame* parameter from didFinishDocumentLoad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/LocalFrameClientImpl.cpp

Issue 2782783002: Remove redundant WebLocalFrame* parameter from didFinishDocumentLoad (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/LocalFrameClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp b/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp

index 6d41c4722aaa74a90af2d742fd2a925c88fa42b0..a28503f0e99171e7e50630dab4516714314d3cc8 100644

--- a/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp

+++ b/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp

@@ -378,7 +378,7 @@ void LocalFrameClientImpl::dispatchDidFinishDocumentLoad() {

// destroy the fake WebLocalFrame that they create, which means that you

// should not put any code touching `this` after the two lines below.

if (m_webFrame->client())

- m_webFrame->client()->didFinishDocumentLoad(m_webFrame);

+ m_webFrame->client()->didFinishDocumentLoad();

}

void LocalFrameClientImpl::dispatchDidLoadResourceFromMemoryCache(