Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2115)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2782783002: Remove redundant WebLocalFrame* parameter from didFinishDocumentLoad (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/renderer/render_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 679773f82aca83ced3397903a82c2e4dd7c899e6..26b79c15c08034e8555bfa46548493d98aae8efa 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -3884,20 +3884,18 @@ void RenderFrameImpl::didChangeIcon(blink::WebLocalFrame* frame,
render_view_->didChangeIcon(frame, icon_type);
}
-void RenderFrameImpl::didFinishDocumentLoad(blink::WebLocalFrame* frame) {
+void RenderFrameImpl::didFinishDocumentLoad() {
TRACE_EVENT1("navigation,benchmark,rail",
"RenderFrameImpl::didFinishDocumentLoad", "id", routing_id_);
- DCHECK_EQ(frame_, frame);
-
Send(new FrameHostMsg_DidFinishDocumentLoad(routing_id_));
for (auto& observer : render_view_->observers())
- observer.DidFinishDocumentLoad(frame);
+ observer.DidFinishDocumentLoad(frame_);
for (auto& observer : observers_)
observer.DidFinishDocumentLoad();
// Check whether we have new encoding name.
- UpdateEncoding(frame, frame->view()->pageEncoding().utf8());
+ UpdateEncoding(frame_, frame_->view()->pageEncoding().utf8());
}
void RenderFrameImpl::runScriptsAtDocumentReady(blink::WebLocalFrame* frame,
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/renderer/render_view_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698