Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2782673002: [Offline pages] Removing obsolete TODOs as part of PE fixit (Closed)

Created:
3 years, 8 months ago by fgorski
Modified:
3 years, 8 months ago
Reviewers:
Dmitry Titov, chili
CC:
chromium-reviews, dewittj+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, agrieve+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Removing obsolete TODOs as part of PE fixit Removing TODOs, which are obsolete or which make no sense to act upon at this point in time. BUG=685523 R=chili@chromium.org Review-Url: https://codereview.chromium.org/2782673002 Cr-Commit-Position: refs/heads/master@{#460562} Committed: https://chromium.googlesource.com/chromium/src/+/9e468760955a427460f9d8ebb604f0e6a24a6c35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -53 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadItem.java View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/android/offline_pages/request_coordinator_factory.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/offline_pages/core/background/request_queue.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M components/offline_pages/core/background/request_queue_store_sql.cc View 5 chunks +1 line, -5 lines 0 comments Download
M components/offline_pages/core/background/request_queue_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/offline_pages/core/background/save_page_request.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/offline_pages/core/offline_page_archiver.h View 1 chunk +0 lines, -6 lines 0 comments Download
M components/offline_pages/core/offline_page_metadata_store_impl_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/offline_pages/core/offline_page_metadata_store_sql.cc View 3 chunks +1 line, -3 lines 0 comments Download
M components/offline_pages/core/offline_page_model_impl.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M components/offline_pages/core/offline_page_test_archiver.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/offline_pages/core/offline_page_test_store.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/offline_pages/core/offline_store_types.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
fgorski
PTAL
3 years, 8 months ago (2017-03-28 18:48:16 UTC) #3
chili
lgtm! thanks :)
3 years, 8 months ago (2017-03-29 18:53:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782673002/1
3 years, 8 months ago (2017-03-29 20:03:21 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-03-29 20:03:23 UTC) #10
fgorski
PTAL
3 years, 8 months ago (2017-03-29 20:04:32 UTC) #12
Dmitry Titov
RS LGTM
3 years, 8 months ago (2017-03-29 20:06:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782673002/1
3 years, 8 months ago (2017-03-29 21:03:48 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 22:54:37 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9e468760955a427460f9d8ebb604...

Powered by Google App Engine
This is Rietveld 408576698