Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Side by Side Diff: components/offline_pages/core/background/request_queue.cc

Issue 2782673002: [Offline pages] Removing obsolete TODOs as part of PE fixit (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/core/background/request_queue.h" 5 #include "components/offline_pages/core/background/request_queue.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 13 matching lines...) Expand all
24 24
25 namespace offline_pages { 25 namespace offline_pages {
26 26
27 namespace { 27 namespace {
28 // Completes the get requests call. 28 // Completes the get requests call.
29 void GetRequestsDone(const RequestQueue::GetRequestsCallback& callback, 29 void GetRequestsDone(const RequestQueue::GetRequestsCallback& callback,
30 bool success, 30 bool success,
31 std::vector<std::unique_ptr<SavePageRequest>> requests) { 31 std::vector<std::unique_ptr<SavePageRequest>> requests) {
32 GetRequestsResult result = 32 GetRequestsResult result =
33 success ? GetRequestsResult::SUCCESS : GetRequestsResult::STORE_FAILURE; 33 success ? GetRequestsResult::SUCCESS : GetRequestsResult::STORE_FAILURE;
34 // TODO(fgorski): Filter out expired requests based on policy.
35 // This may trigger the purging if necessary.
36 // Also this may be turned into a method on the request queue or add a policy
37 // parameter in the process.
38 callback.Run(result, std::move(requests)); 34 callback.Run(result, std::move(requests));
39 } 35 }
40 36
41 // Completes the add request call. 37 // Completes the add request call.
42 void AddRequestDone(const RequestQueue::AddRequestCallback& callback, 38 void AddRequestDone(const RequestQueue::AddRequestCallback& callback,
43 const SavePageRequest& request, 39 const SavePageRequest& request,
44 ItemActionStatus status) { 40 ItemActionStatus status) {
45 AddRequestResult result; 41 AddRequestResult result;
46 switch (status) { 42 switch (status) {
47 case ItemActionStatus::SUCCESS: 43 case ItemActionStatus::SUCCESS:
(...skipping 23 matching lines...) Expand all
71 RequestQueue::~RequestQueue() {} 67 RequestQueue::~RequestQueue() {}
72 68
73 void RequestQueue::GetRequests(const GetRequestsCallback& callback) { 69 void RequestQueue::GetRequests(const GetRequestsCallback& callback) {
74 std::unique_ptr<Task> task(new GetRequestsTask( 70 std::unique_ptr<Task> task(new GetRequestsTask(
75 store_.get(), base::Bind(&GetRequestsDone, callback))); 71 store_.get(), base::Bind(&GetRequestsDone, callback)));
76 task_queue_.AddTask(std::move(task)); 72 task_queue_.AddTask(std::move(task));
77 } 73 }
78 74
79 void RequestQueue::AddRequest(const SavePageRequest& request, 75 void RequestQueue::AddRequest(const SavePageRequest& request,
80 const AddRequestCallback& callback) { 76 const AddRequestCallback& callback) {
81 // TODO(fgorski): check that request makes sense.
82 // TODO(fgorski): check that request does not violate policy.
83 std::unique_ptr<AddRequestTask> task(new AddRequestTask( 77 std::unique_ptr<AddRequestTask> task(new AddRequestTask(
84 store_.get(), request, base::Bind(&AddRequestDone, callback, request))); 78 store_.get(), request, base::Bind(&AddRequestDone, callback, request)));
85 task_queue_.AddTask(std::move(task)); 79 task_queue_.AddTask(std::move(task));
86 } 80 }
87 81
88 void RequestQueue::RemoveRequests(const std::vector<int64_t>& request_ids, 82 void RequestQueue::RemoveRequests(const std::vector<int64_t>& request_ids,
89 const UpdateCallback& callback) { 83 const UpdateCallback& callback) {
90 std::unique_ptr<Task> task( 84 std::unique_ptr<Task> task(
91 new RemoveRequestsTask(store_.get(), request_ids, callback)); 85 new RemoveRequestsTask(store_.get(), request_ids, callback));
92 task_queue_.AddTask(std::move(task)); 86 task_queue_.AddTask(std::move(task));
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 weak_ptr_factory_.GetWeakPtr()))); 156 weak_ptr_factory_.GetWeakPtr())));
163 task_queue_.AddTask(std::move(task)); 157 task_queue_.AddTask(std::move(task));
164 } 158 }
165 159
166 void RequestQueue::InitializeStoreDone(bool success) { 160 void RequestQueue::InitializeStoreDone(bool success) {
167 // TODO(fgorski): Result can be ignored for now. Report UMA in future. 161 // TODO(fgorski): Result can be ignored for now. Report UMA in future.
168 // No need to pass the result up to RequestCoordinator. 162 // No need to pass the result up to RequestCoordinator.
169 } 163 }
170 164
171 } // namespace offline_pages 165 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698